Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

Issue 1621923002: [DevTools] Remove InspectorState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
index efaec682ab53966ae8991bc700c9e9f7683d7b49..835bc2f2566197d8ca392b94bc14451ca3eb55e6 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
@@ -32,7 +32,6 @@
#include "core/InspectorFrontend.h"
#include "core/inspector/IdentifiersFactory.h"
-#include "core/inspector/InspectorState.h"
#include "core/inspector/InstrumentingAgents.h"
#include "core/inspector/PageConsoleAgent.h"
#include "platform/weborigin/KURL.h"
@@ -72,7 +71,7 @@ void InspectorWorkerAgent::init()
void InspectorWorkerAgent::restore()
{
- if (m_state->getBoolean(WorkerAgentState::workerInspectionEnabled))
+ if (m_state->booleanProperty(WorkerAgentState::workerInspectionEnabled, false))
createWorkerAgentClientsForExistingWorkers();
}
@@ -132,14 +131,14 @@ void InspectorWorkerAgent::setTracingSessionId(const String& sessionId)
bool InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart()
{
- return m_state->getBoolean(WorkerAgentState::autoconnectToWorkers);
+ return m_state->booleanProperty(WorkerAgentState::autoconnectToWorkers, false);
}
void InspectorWorkerAgent::didStartWorker(WorkerInspectorProxy* workerInspectorProxy, const KURL& url)
{
String id = "dedicated:" + IdentifiersFactory::createIdentifier();
m_workerInfos.set(workerInspectorProxy, WorkerInfo(url.string(), id));
- if (frontend() && m_state->getBoolean(WorkerAgentState::workerInspectionEnabled))
+ if (frontend() && m_state->booleanProperty(WorkerAgentState::workerInspectionEnabled, false))
createWorkerAgentClient(workerInspectorProxy, url.string(), id);
if (!m_tracingSessionId.isEmpty())
workerInspectorProxy->writeTimelineStartedEvent(m_tracingSessionId, id);
@@ -178,7 +177,7 @@ void InspectorWorkerAgent::createWorkerAgentClient(WorkerInspectorProxy* workerI
m_idToClient.set(id, client.release());
ASSERT(frontend());
- bool autoconnectToWorkers = m_state->getBoolean(WorkerAgentState::autoconnectToWorkers);
+ bool autoconnectToWorkers = m_state->booleanProperty(WorkerAgentState::autoconnectToWorkers, false);
if (autoconnectToWorkers)
rawClient->connectToWorker();
frontend()->workerCreated(id, url, autoconnectToWorkers);

Powered by Google App Engine
This is Rietveld 408576698