third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp - Issue 1621923002: [DevTools] Remove InspectorState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1621923002: [DevTools] Remove InspectorState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

index 1fe4c09225c3bcf16576dae33d89b4917c53413a..90d4547e25b64d021630787bc340cfc56eef6233 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

@@ -35,7 +35,6 @@

#include "core/frame/LocalDOMWindow.h"

#include "core/inspector/InjectedScript.h"

#include "core/inspector/InjectedScriptHost.h"

-#include "core/inspector/InspectorState.h"

#include "core/inspector/RemoteObjectId.h"

#include "platform/Timer.h"

#include "wtf/CurrentTime.h"

@@ -203,10 +202,10 @@ InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent()

void InspectorHeapProfilerAgent::restore()

{

- if (m_state->getBoolean(HeapProfilerAgentState::heapProfilerEnabled))

+ if (m_state->booleanProperty(HeapProfilerAgentState::heapProfilerEnabled, false))

frontend()->resetProfiles();

- if (m_state->getBoolean(HeapProfilerAgentState::heapObjectsTrackingEnabled))

- startTrackingHeapObjectsInternal(m_state->getBoolean(HeapProfilerAgentState::allocationTrackingEnabled));

+ if (m_state->booleanProperty(HeapProfilerAgentState::heapObjectsTrackingEnabled, false))

+ startTrackingHeapObjectsInternal(m_state->booleanProperty(HeapProfilerAgentState::allocationTrackingEnabled, false));

}

void InspectorHeapProfilerAgent::collectGarbage(ErrorString*)