third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h - Issue 1621923002: [DevTools] Remove InspectorState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h

Issue 1621923002: [DevTools] Remove InspectorState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h

index 61ad489735674316a0a320843f648a4af6b7f0d0..64ca1ce1590fed7694d228390d36c71883810dec 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h

@@ -21,7 +21,7 @@ public:

explicit V8ProfilerAgentImpl(v8::Isolate*);

~V8ProfilerAgentImpl() override;

- void setInspectorState(InspectorState* state) override { m_state = state; }

+ void setInspectorState(PassRefPtr<JSONObject> state) override { m_state = state; }

void setFrontend(InspectorFrontend::Profiler* frontend) override { m_frontend = frontend; }

void clearFrontend() override;

void restore() override;

@@ -48,7 +48,7 @@ private:

bool isRecording() const;

v8::Isolate* m_isolate;

- InspectorState* m_state;

+ RefPtr<JSONObject> m_state;

InspectorFrontend::Profiler* m_frontend;

bool m_enabled;

bool m_recordingCPUProfile;