third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h - Issue 1621923002: [DevTools] Remove InspectorState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

Issue 1621923002: [DevTools] Remove InspectorState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

index 7477dc145b389033ef65b8dcd0976de67ff04e9c..ef182073b6d8a243beff03ebc021d40908e8d474 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

@@ -59,7 +59,7 @@ public:

~V8DebuggerAgentImpl() override;

DECLARE_TRACE();

- void setInspectorState(InspectorState*) override;

+ void setInspectorState(PassRefPtr<JSONObject>) override;

void setFrontend(InspectorFrontend::Debugger* frontend) override { m_frontend = frontend; }

void clearFrontend() override;

void restore() override;

@@ -205,7 +205,7 @@ private:

V8DebuggerImpl* m_debugger;

int m_contextGroupId;

bool m_enabled;

- InspectorState* m_state;

+ RefPtr<JSONObject> m_state;

InspectorFrontend::Debugger* m_frontend;

v8::Isolate* m_isolate;

RefPtr<ScriptState> m_pausedScriptState;