third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp - Issue 1621923002: [DevTools] Remove InspectorState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1621923002: [DevTools] Remove InspectorState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

index de46f84c29315839db5b7a90e4b778529ab1e647..39ee87c8ef08e2e76d5a5d2c36f461677c8f1180 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

@@ -30,7 +30,6 @@

#include "core/inspector/IdentifiersFactory.h"

#include "core/inspector/InjectedScript.h"

#include "core/inspector/InjectedScriptManager.h"

-#include "core/inspector/InspectorState.h"

#include "core/inspector/InstrumentingAgents.h"

#include "core/inspector/ScriptArguments.h"

#include "core/inspector/ScriptAsyncCallStack.h"

@@ -94,7 +93,7 @@ void InspectorConsoleAgent::disable(ErrorString*)

void InspectorConsoleAgent::restore()

{

- if (m_state->getBoolean(ConsoleAgentState::consoleMessagesEnabled)) {

+ if (m_state->booleanProperty(ConsoleAgentState::consoleMessagesEnabled, false)) {

frontend()->messagesCleared();

ErrorString error;

enable(&error);