[builtins] Refactor the remaining Date builtins.

[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}

Committed: https://crrev.com/9e217ee4900a6b598967039e936af12dc3c4d06b
Cr-Commit-Position: refs/heads/master@{#33231}

[Benedikt Meurer, 2016-01-11 14:40:23]

Hey Yang,

Final refactoring for Date. :-)
Please take a look.

Thanks,
Benedikt

[Yang, 2016-01-12 06:20:57]

LGTM with comments, all of which can be either dismissed or done in a separate
CL.

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc#newcode2125
src/builtins.cc:2125: enum ToDateStringMode { kDateOnly, kTimeOnly, kDateAndTime
};
At some point we probably should split up builtins.cc :)

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc#newcode2384
src/builtins.cc:2384: int64_t local_time_ms =
isolate->date_cache()->ToLocal(time_ms);
We got these kind of calculations in every one of these builtins. I'd suggest
using a class to encapsulate all of these. Something along the line of
class ComputeDate {
  ComputeDate(Object* date) {
    valid_ = !std::isnan(date->value()->Number());
    time_ms_ = ...
    ...
  }
  inline int milliseconds() { return time_within_day % 1000; }
  inline int seconds() { return time_within_day / 1000 % 60; }
  ...
 private:
  bool valid_;
  int64_t time_ms_;
  int64_t local_time_ms_;
  int days_;
  int time_within_day_;
}

Then those setters would be just a matter of using this class for seconds,
minutes, hours, etc, replace the one we are interested in, and use MakeDate to
get the result. Would save quite some redundancy.

Going a step further, you could even put MakeDate and SetLocalDateValue into the
destructor of that class.

https://codereview.chromium.org/1579613002/diff/1/src/builtins.h
File src/builtins.h (right):

https://codereview.chromium.org/1579613002/diff/1/src/builtins.h#newcode221
src/builtins.h:221: V(DatePrototypeGetDate, BUILTIN, UNINITIALIZED,
kNoExtraICState)             \
Can we move these up to the other Date builtins?

https://codereview.chromium.org/1579613002/diff/1/src/js/date.js
File src/js/date.js (right):

https://codereview.chromium.org/1579613002/diff/1/src/js/date.js#newcode39
src/js/date.js:39: utils.InstallFunctions(GlobalDate.prototype, DONT_ENUM, [
As discussed, we could put this into json.js as well, and completely remove
date.js.

[Benedikt Meurer, 2016-01-12 06:26:55]

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc#newcode2125
src/builtins.cc:2125: enum ToDateStringMode { kDateOnly, kTimeOnly, kDateAndTime
};
Definitely.

https://codereview.chromium.org/1579613002/diff/1/src/builtins.cc#newcode2384
src/builtins.cc:2384: int64_t local_time_ms =
isolate->date_cache()->ToLocal(time_ms);
Yeah, my plan was to unify all the date mess (including the date.h awesomeness
and the dateparser) at some point, because a lot of this is even duplicated with
stuff in date.cc.

https://codereview.chromium.org/1579613002/diff/1/src/builtins.h
File src/builtins.h (right):

https://codereview.chromium.org/1579613002/diff/1/src/builtins.h#newcode221
src/builtins.h:221: V(DatePrototypeGetDate, BUILTIN, UNINITIALIZED,
kNoExtraICState)             \
No this is the assembly list :-)

https://codereview.chromium.org/1579613002/diff/1/src/js/date.js
File src/js/date.js (right):

https://codereview.chromium.org/1579613002/diff/1/src/js/date.js#newcode39
src/js/date.js:39: utils.InstallFunctions(GlobalDate.prototype, DONT_ENUM, [
On 2016/01/12 06:20:57, Yang wrote:
> As discussed, we could put this into json.js as well, and completely remove
> date.js.

Done.

[Benedikt Meurer, 2016-01-12 06:27:13]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
R=yangguo@chromium.org
==========

[Benedikt Meurer, 2016-01-12 06:27:22]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-01-12 06:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1579613002/#ps20001
(title: "Address comments. Fixes.")

[commit-bot: I haz the power, 2016-01-12 06:27:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579613002/20001

[Benedikt Meurer, 2016-01-12 07:30:42]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
R=yangguo@chromium.org
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

[Benedikt Meurer, 2016-01-12 07:32:56]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-01-12 07:58:18]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

[Benedikt Meurer, 2016-01-12 07:58:26]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-01-12 07:58:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579613002/20001

[commit-bot: I haz the power, 2016-01-12 08:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 08:14:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Benedikt Meurer, 2016-01-12 09:09:42]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

[Benedikt Meurer, 2016-01-12 09:09:49]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-01-12 09:09:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579613002/20001

[commit-bot: I haz the power, 2016-01-12 09:12:07]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

[commit-bot: I haz the power, 2016-01-12 09:12:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 09:13:04]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

[commit-bot: I haz the power, 2016-01-12 09:13:05]

Patchset 2 (id:??) landed as
https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}

[Michael Achenbach, 2016-01-12 10:13:50]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1574223002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2....

[Michael Achenbach, 2016-01-12 10:25:41]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

[Benedikt Meurer, 2016-01-12 10:27:23]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-01-12 10:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1579613002/#ps40001
(title: "As per offline discussion, remove the weird test, which does not add a
lot of value.")

[commit-bot: I haz the power, 2016-01-12 10:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579613002/40001

[commit-bot: I haz the power, 2016-01-12 10:47:32]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

[commit-bot: I haz the power, 2016-01-12 10:47:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 10:48:34]

Description was changed from

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}
==========

to

==========
[builtins] Refactor the remaining Date builtins.

This migrates the remaining Date builtins to C++ and removes obsolete
intrinsics and JavaScript wrappers. This reduces the overhead imposed
by the Date builtins, and will allow us to optimize them later in the
TurboFan compiler, while the interpreter doesn't need to worry about
them.

R=yangguo@chromium.org
BUG=chromium:576574
LOG=n

Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281
Cr-Commit-Position: refs/heads/master@{#33228}

Committed: https://crrev.com/9e217ee4900a6b598967039e936af12dc3c4d06b
Cr-Commit-Position: refs/heads/master@{#33231}
==========

[commit-bot: I haz the power, 2016-01-12 10:48:35]

Patchset 3 (id:??) landed as
https://crrev.com/9e217ee4900a6b598967039e936af12dc3c4d06b
Cr-Commit-Position: refs/heads/master@{#33231}