src/runtime/runtime.h - Issue 1579613002: [builtins] Refactor the remaining Date builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime.h

Issue 1579613002: [builtins] Refactor the remaining Date builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: As per offline discussion, remove the weird test, which does not add a lot of value. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime.h

diff --git a/src/runtime/runtime.h b/src/runtime/runtime.h

index df50cb484ba693dd71a6f7ce6de3ed674212d5d9..283087ae06aac3ab0fd2ba29ba7b3b77038b4cb4 100644

--- a/src/runtime/runtime.h

+++ b/src/runtime/runtime.h

@@ -137,14 +137,9 @@ namespace internal {

#define FOR_EACH_INTRINSIC_DATE(F) \

- F(DateMakeDay, 2, 1) \

- F(DateSetValue, 3, 1) \

F(IsDate, 1, 1) \

- F(ThrowNotDateError, 0, 1) \

F(DateCurrentTime, 0, 1) \

- F(DateLocalTimezone, 1, 1) \

- F(DateCacheVersion, 0, 1) \

- F(DateField, 2 /* date object, field index */, 1)

+ F(ThrowNotDateError, 0, 1)

#define FOR_EACH_INTRINSIC_DEBUG(F) \

« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-date.cc » ('j') | no next file with comments »