src/crankshaft/hydrogen-instructions.cc - Issue 1579613002: [builtins] Refactor the remaining Date builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1579613002: [builtins] Refactor the remaining Date builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: As per offline discussion, remove the weird test, which does not add a lot of value. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen-instructions.cc

diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc

index 38998e2f96b01a71a81b857ea7b7f39bbcaee5a4..e2e026fb5f04d71e6ec85a2f9053940d331be72b 100644

--- a/src/crankshaft/hydrogen-instructions.cc

+++ b/src/crankshaft/hydrogen-instructions.cc

@@ -849,7 +849,6 @@ bool HInstruction::CanDeoptimize() {

case HValue::kCheckSmi:

case HValue::kCheckValue:

case HValue::kClampToUint8:

- case HValue::kDateField:

case HValue::kDeoptimize:

case HValue::kDiv:

case HValue::kForInCacheArray:

« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »