src/full-codegen/full-codegen.h - Issue 1579613002: [builtins] Refactor the remaining Date builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.h

Issue 1579613002: [builtins] Refactor the remaining Date builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: As per offline discussion, remove the weird test, which does not add a lot of value. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.h

diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h

index b0e8ef39314889fdee6b7d53dcf5b5b51b3534f8..52eddafa1a1a6e30ab8a6b1fa1f7661b39cc7805 100644

--- a/src/full-codegen/full-codegen.h

+++ b/src/full-codegen/full-codegen.h

@@ -482,7 +482,6 @@ class FullCodeGenerator: public AstVisitor {

F(ValueOf) \

F(SetValueOf) \

F(IsDate) \

- F(DateField) \

F(StringCharFromCode) \

F(StringCharAt) \

F(OneByteSeqStringSetChar) \