Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: test/cctest/test-date.cc

Issue 1579613002: [builtins] Refactor the remaining Date builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: As per offline discussion, remove the weird test, which does not add a lot of value. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-date.cc ('k') | test/mjsunit/date.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-date.cc
diff --git a/test/cctest/test-date.cc b/test/cctest/test-date.cc
index a43ef0637bf931255d28f2797b1a9fedccbada00..67b950159292d2e15c648008f2fb7d9fd4f151f4 100644
--- a/test/cctest/test-date.cc
+++ b/test/cctest/test-date.cc
@@ -166,31 +166,3 @@ TEST(DaylightSavingsTime) {
CheckDST(august_20 + 2 * 3600 - 1000);
CheckDST(august_20);
}
-
-
-TEST(DateCacheVersion) {
- FLAG_allow_natives_syntax = true;
- v8::Isolate* isolate = CcTest::isolate();
- v8::Isolate::Scope isolate_scope(isolate);
- v8::HandleScope scope(isolate);
- v8::Local<v8::Context> context = v8::Context::New(isolate);
- v8::Context::Scope context_scope(context);
- v8::Local<v8::Array> date_cache_version =
- v8::Local<v8::Array>::Cast(CompileRun("%DateCacheVersion()"));
-
- CHECK_EQ(1, static_cast<int32_t>(date_cache_version->Length()));
- CHECK(date_cache_version->Get(context, 0).ToLocalChecked()->IsNumber());
- CHECK_EQ(0.0, date_cache_version->Get(context, 0)
- .ToLocalChecked()
- ->NumberValue(context)
- .FromJust());
-
- v8::Date::DateTimeConfigurationChangeNotification(isolate);
-
- CHECK_EQ(1, static_cast<int32_t>(date_cache_version->Length()));
- CHECK(date_cache_version->Get(context, 0).ToLocalChecked()->IsNumber());
- CHECK_EQ(1.0, date_cache_version->Get(context, 0)
- .ToLocalChecked()
- ->NumberValue(context)
- .FromJust());
-}
« no previous file with comments | « src/runtime/runtime-date.cc ('k') | test/mjsunit/date.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698