Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/compiler/linkage.cc

Issue 1579613002: [builtins] Refactor the remaining Date builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: As per offline discussion, remove the weird test, which does not add a lot of value. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-intrinsic-lowering.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/scopes.h" 5 #include "src/ast/scopes.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/compiler/common-operator.h" 8 #include "src/compiler/common-operator.h"
9 #include "src/compiler/frame.h" 9 #include "src/compiler/frame.h"
10 #include "src/compiler/linkage.h" 10 #include "src/compiler/linkage.h"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 149
150 // static 150 // static
151 int Linkage::FrameStateInputCount(Runtime::FunctionId function) { 151 int Linkage::FrameStateInputCount(Runtime::FunctionId function) {
152 // Most runtime functions need a FrameState. A few chosen ones that we know 152 // Most runtime functions need a FrameState. A few chosen ones that we know
153 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize 153 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize
154 // are blacklisted here and can be called without a FrameState. 154 // are blacklisted here and can be called without a FrameState.
155 switch (function) { 155 switch (function) {
156 case Runtime::kAllocateInTargetSpace: 156 case Runtime::kAllocateInTargetSpace:
157 case Runtime::kCreateIterResultObject: 157 case Runtime::kCreateIterResultObject:
158 case Runtime::kDateField:
159 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe? 158 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?
160 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe? 159 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?
161 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe? 160 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?
162 case Runtime::kFinalizeClassDefinition: // TODO(conradw): Is it safe? 161 case Runtime::kFinalizeClassDefinition: // TODO(conradw): Is it safe?
163 case Runtime::kForInDone: 162 case Runtime::kForInDone:
164 case Runtime::kForInStep: 163 case Runtime::kForInStep:
165 case Runtime::kGetSuperConstructor: 164 case Runtime::kGetSuperConstructor:
166 case Runtime::kNewClosure: 165 case Runtime::kNewClosure:
167 case Runtime::kNewClosure_Tenured: 166 case Runtime::kNewClosure_Tenured:
168 case Runtime::kNewFunctionContext: 167 case Runtime::kNewFunctionContext:
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 } else { 530 } else {
532 DCHECK(loc == regloc(kContextRegister)); 531 DCHECK(loc == regloc(kContextRegister));
533 return LinkageLocation::ForCalleeFrameSlot(Frame::kContextSlot); 532 return LinkageLocation::ForCalleeFrameSlot(Frame::kContextSlot);
534 } 533 }
535 } 534 }
536 535
537 536
538 } // namespace compiler 537 } // namespace compiler
539 } // namespace internal 538 } // namespace internal
540 } // namespace v8 539 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-intrinsic-lowering.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698