Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, jam, eroman, darin-cc_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

Make net and ipc explicitly use the base namespace for Values. They're currently relying on a using in values.h that we want to remove. I removed several usings in net for consistency. BUG= R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206187

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -321 lines) Patch
M ipc/ipc_message_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 11 chunks +40 lines, -36 lines 0 comments Download
M net/base/capturing_net_log.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/file_stream_net_log_parameters.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_log.cc View 7 chunks +34 lines, -33 lines 0 comments Download
M net/base/net_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/cert/crl_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M net/disk_cache/net_log_parameters.cc View 4 chunks +28 lines, -23 lines 0 comments Download
M net/dns/dns_transaction.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/ftp/ftp_ctrl_response_buffer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_pipelined_connection_impl.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M net/http/http_pipelined_host_forced.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M net/http/http_pipelined_host_impl.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M net/http/http_pipelined_host_pool.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_request_headers.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_stream_parser.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M net/proxy/proxy_script_decider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 5 chunks +26 lines, -25 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/nss_ssl_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/socket_net_log_params.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/ssl_error_params.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_header_block.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M net/test/spawned_test_server/local_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/dns_fuzz_stub/dns_fuzz_stub.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/udp/udp_net_log_parameters.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/url_request/url_request_netlog_params.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/websockets/websocket_net_log_params.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/websockets/websocket_net_log_params_unittest.cc View 2 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 6 months ago (2013-06-11 21:32:11 UTC) #1
willchan no longer on Chromium
lgtm
7 years, 6 months ago (2013-06-11 21:37:36 UTC) #2
brettw
7 years, 6 months ago (2013-06-13 22:50:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r206187.

Powered by Google App Engine
This is Rietveld 408576698