Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: ipc/ipc_message_unittest.cc

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_unittest.cc
diff --git a/ipc/ipc_message_unittest.cc b/ipc/ipc_message_unittest.cc
index 6a40acd5f824d6191d2ad9c61be73ed184e8858d..971314a290c06414722135ca08b281f419ca1ee8 100644
--- a/ipc/ipc_message_unittest.cc
+++ b/ipc/ipc_message_unittest.cc
@@ -14,7 +14,7 @@
namespace {
TEST(IPCMessageTest, ListValue) {
- ListValue input;
+ base::ListValue input;
input.Set(0, new base::FundamentalValue(42.42));
input.Set(1, new base::StringValue("forty"));
input.Set(2, base::Value::CreateNullValue());
@@ -22,7 +22,7 @@ TEST(IPCMessageTest, ListValue) {
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
- ListValue output;
+ base::ListValue output;
PickleIterator iter(msg);
EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
@@ -36,17 +36,17 @@ TEST(IPCMessageTest, ListValue) {
}
TEST(IPCMessageTest, DictionaryValue) {
- DictionaryValue input;
- input.Set("null", Value::CreateNullValue());
+ base::DictionaryValue input;
+ input.Set("null", base::Value::CreateNullValue());
input.Set("bool", new base::FundamentalValue(true));
input.Set("int", new base::FundamentalValue(42));
input.SetWithoutPathExpansion("int.with.dot", new base::FundamentalValue(43));
- scoped_ptr<DictionaryValue> subdict(new DictionaryValue());
+ scoped_ptr<base::DictionaryValue> subdict(new base::DictionaryValue());
subdict->Set("str", new base::StringValue("forty two"));
subdict->Set("bool", new base::FundamentalValue(false));
- scoped_ptr<ListValue> sublist(new ListValue());
+ scoped_ptr<base::ListValue> sublist(new base::ListValue());
sublist->Set(0, new base::FundamentalValue(42.42));
sublist->Set(1, new base::StringValue("forty"));
sublist->Set(2, new base::StringValue("two"));
@@ -57,7 +57,7 @@ TEST(IPCMessageTest, DictionaryValue) {
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
- DictionaryValue output;
+ base::DictionaryValue output;
PickleIterator iter(msg);
EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
« no previous file with comments | « no previous file | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698