Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: net/dns/dns_transaction.cc

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/net_log_parameters.cc ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_transaction.cc
diff --git a/net/dns/dns_transaction.cc b/net/dns/dns_transaction.cc
index fef5f26ba647b79f9eae85e21f9b7f56d3356775..6d377104e3e63e6a98eceb5b0a280c9765b0480d 100644
--- a/net/dns/dns_transaction.cc
+++ b/net/dns/dns_transaction.cc
@@ -57,10 +57,10 @@ bool IsIPLiteral(const std::string& hostname) {
return ParseIPLiteralToNumber(hostname, &ip);
}
-Value* NetLogStartCallback(const std::string* hostname,
+base::Value* NetLogStartCallback(const std::string* hostname,
uint16 qtype,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetString("hostname", *hostname);
dict->SetInteger("query_type", qtype);
return dict;
@@ -100,7 +100,7 @@ class DnsAttempt {
Value* NetLogResponseCallback(NetLog::LogLevel log_level) const {
DCHECK(GetResponse()->IsValid());
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetInteger("rcode", GetResponse()->rcode());
dict->SetInteger("answer_count", GetResponse()->answer_count());
GetSocketNetLog().source().AddToEventParameters(dict);
« no previous file with comments | « net/disk_cache/net_log_parameters.cc ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698