Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: net/dns/host_resolver_impl.cc

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/ftp/ftp_ctrl_response_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_resolver_impl.cc
diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc
index f0d10deb3df429c97bfab68605ae08d42285bc76..6c41181ac06bd52290456a2039691bd06d23ada4 100644
--- a/net/dns/host_resolver_impl.cc
+++ b/net/dns/host_resolver_impl.cc
@@ -275,7 +275,7 @@ base::Value* NetLogProcTaskFailedCallback(uint32 attempt_number,
int net_error,
int os_error,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
if (attempt_number)
dict->SetInteger("attempt_number", attempt_number);
@@ -308,7 +308,7 @@ base::Value* NetLogProcTaskFailedCallback(uint32 attempt_number,
base::Value* NetLogDnsTaskFailedCallback(int net_error,
int dns_error,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetInteger("net_error", net_error);
if (dns_error)
dict->SetInteger("dns_error", dns_error);
@@ -320,7 +320,7 @@ base::Value* NetLogDnsTaskFailedCallback(int net_error,
base::Value* NetLogRequestInfoCallback(const NetLog::Source& source,
const HostResolver::RequestInfo* info,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
source.AddToEventParameters(dict);
dict->SetString("host", info->host_port_pair().ToString());
@@ -336,7 +336,7 @@ base::Value* NetLogRequestInfoCallback(const NetLog::Source& source,
base::Value* NetLogJobCreationCallback(const NetLog::Source& source,
const std::string* host,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
source.AddToEventParameters(dict);
dict->SetString("host", *host);
return dict;
@@ -346,7 +346,7 @@ base::Value* NetLogJobCreationCallback(const NetLog::Source& source,
base::Value* NetLogJobAttachCallback(const NetLog::Source& source,
RequestPriority priority,
NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
source.AddToEventParameters(dict);
dict->SetInteger("priority", priority);
return dict;
@@ -1918,7 +1918,7 @@ base::Value* HostResolverImpl::GetDnsConfigAsValue() const {
// for it.
const DnsConfig* dns_config = dns_client_->GetConfig();
if (dns_config == NULL)
- return new DictionaryValue();
+ return new base::DictionaryValue();
return dns_config->ToValue();
}
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/ftp/ftp_ctrl_response_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698