Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: net/http/http_pipelined_connection_impl.cc

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction_spdy3_unittest.cc ('k') | net/http/http_pipelined_host_forced.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_pipelined_connection_impl.cc
diff --git a/net/http/http_pipelined_connection_impl.cc b/net/http/http_pipelined_connection_impl.cc
index 471b26adef98367f1a3f1665100ce3f120a529a7..b72f8e8cc89ee0027bfef791e2dad200b58530d0 100644
--- a/net/http/http_pipelined_connection_impl.cc
+++ b/net/http/http_pipelined_connection_impl.cc
@@ -18,34 +18,31 @@
#include "net/http/http_version.h"
#include "net/socket/client_socket_handle.h"
-using base::DictionaryValue;
-using base::Value;
-
namespace net {
namespace {
-Value* NetLogReceivedHeadersCallback(const NetLog::Source& source,
- const std::string* feedback,
- NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue;
+base::Value* NetLogReceivedHeadersCallback(const NetLog::Source& source,
+ const std::string* feedback,
+ NetLog::LogLevel /* log_level */) {
+ base::DictionaryValue* dict = new base::DictionaryValue;
source.AddToEventParameters(dict);
dict->SetString("feedback", *feedback);
return dict;
}
-Value* NetLogStreamClosedCallback(const NetLog::Source& source,
- bool not_reusable,
- NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue;
+base::Value* NetLogStreamClosedCallback(const NetLog::Source& source,
+ bool not_reusable,
+ NetLog::LogLevel /* log_level */) {
+ base::DictionaryValue* dict = new base::DictionaryValue;
source.AddToEventParameters(dict);
dict->SetBoolean("not_reusable", not_reusable);
return dict;
}
-Value* NetLogHostPortPairCallback(const HostPortPair* host_port_pair,
- NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue;
+base::Value* NetLogHostPortPairCallback(const HostPortPair* host_port_pair,
+ NetLog::LogLevel /* log_level */) {
+ base::DictionaryValue* dict = new base::DictionaryValue;
dict->SetString("host_and_port", host_port_pair->ToString());
return dict;
}
« no previous file with comments | « net/http/http_network_transaction_spdy3_unittest.cc ('k') | net/http/http_pipelined_host_forced.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698