Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: net/websockets/websocket_net_log_params.cc

Issue 15662008: Make net and ipc explicitly use the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_throttler_entry.cc ('k') | net/websockets/websocket_net_log_params_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_net_log_params.cc
diff --git a/net/websockets/websocket_net_log_params.cc b/net/websockets/websocket_net_log_params.cc
index f2b33b19e3fd60f3dfa4e9669e3c3f7897b26c7b..dd9bddebf6b006f73b6ad6027de9e6b20b89c62e 100644
--- a/net/websockets/websocket_net_log_params.cc
+++ b/net/websockets/websocket_net_log_params.cc
@@ -9,10 +9,11 @@
namespace net {
-Value* NetLogWebSocketHandshakeCallback(const std::string* headers,
- NetLog::LogLevel /* log_level */) {
- DictionaryValue* dict = new DictionaryValue();
- ListValue* header_list = new ListValue();
+base::Value* NetLogWebSocketHandshakeCallback(
+ const std::string* headers,
+ NetLog::LogLevel /* log_level */) {
+ base::DictionaryValue* dict = new base::DictionaryValue();
+ base::ListValue* header_list = new base::ListValue();
size_t last = 0;
size_t headers_size = headers->size();
@@ -25,7 +26,7 @@ Value* NetLogWebSocketHandshakeCallback(const std::string* headers,
pos += 2;
last = pos;
- header_list->Append(new StringValue(entry));
+ header_list->Append(new base::StringValue(entry));
if (entry.empty()) {
// Dump WebSocket key3.
@@ -33,7 +34,7 @@ Value* NetLogWebSocketHandshakeCallback(const std::string* headers,
for (; pos < headers_size; ++pos) {
key += base::StringPrintf("\\x%02x", (*headers)[pos] & 0xff);
}
- header_list->Append(new StringValue(key));
+ header_list->Append(new base::StringValue(key));
break;
}
} else {
« no previous file with comments | « net/url_request/url_request_throttler_entry.cc ('k') | net/websockets/websocket_net_log_params_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698