Change IPEndpoint::address() to return a net::IPAddress

Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10

Committed: https://crrev.com/98acb9b5250fac2902aff41afa71496da5cf26cd
Cr-Commit-Position: refs/heads/master@{#371750}

[martijnc, 2016-01-08 16:13:25]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-01-08 17:51:13]

Description was changed from

==========
Rename IPEndpoint::address() to IPEndpoint::address_number()

BUG=496258
==========

to

==========
Rename IPEndpoint::address() to IPEndpoint::address_number()

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress. This CL renames IPEndpoint::address() to
IPEndpoint::address_number() to make that possible. This is the first part of a
two step process:

  * Rename IPEndpoint::address() to IPEndpoint::address_number() (this CL)
  * Add IPEndpoint::address() that returns a net::IPAddress and deprecate
IPEndpoint::address_number() (follow up CL)

BUG=496258

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

[martijnc, 2016-01-08 17:51:13]

martijn@martijnc.be changed reviewers:
+ eroman@chromium.org

[martijnc, 2016-01-08 18:47:13]

eroman: can you take a look at net/*? Thanks!

This patch only renames the method but still touches a lot of files (which will
be hard to get reviewed?). Would it be better to split this CL up per top-level
directory (a bit messier)?

[martijnc, 2016-01-12 20:57:55]

Patchset #3 (id:60001) has been deleted

[mmenke, 2016-01-12 22:52:02]

On 2016/01/08 18:47:13, martijnc wrote:
> eroman: can you take a look at net/*? Thanks!
> 
> This patch only renames the method but still touches a lot of files (which
will
> be hard to get reviewed?). Would it be better to split this CL up per
top-level
> directory (a bit messier)?

I'll take a look at this tomorrow, unless Eric chimes in by then.  This change
is simple enough that I don't think there's any benefit ti breaking it up into
multiple CLs.

[eroman, 2016-01-13 00:27:57]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-01-13 00:27:58]

lgtm

https://codereview.chromium.org/1565303002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/pepper/pepper_socket_utils.cc (right):

https://codereview.chromium.org/1565303002/diff/40001/content/browser/rendere...
content/browser/renderer_host/pepper/pepper_socket_utils.cc:184: if
(isLoopbackAddress(address.address_number())) {
(aside) Looks like these existing functions are incorrectly named. Filed
https://code.google.com/p/chromium/issues/detail?id=576934

https://codereview.chromium.org/1565303002/diff/40001/media/cast/net/udp_tran...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/1565303002/diff/40001/media/cast/net/udp_tran...
media/cast/net/udp_transport.cc:28: return std::equal(empty_addr.begin(),
empty_addr.end(),
I have seen this pattern in some other places. Might be worth adding a
IPAddress::IsZero() helper. Or at the very list simplifying this line to
empty_addr == addr.address.bytes().

Either way, save this for another CL if you want to do it (so we keep this
change just about the IPAddress refactor).

https://codereview.chromium.org/1565303002/diff/40001/media/cast/net/udp_tran...
media/cast/net/udp_transport.cc:35: std::equal(addr1.address_number().begin(),
Hmm, this looks wrong. Filed
https://code.google.com/p/chromium/issues/detail?id=576943

[eroman, 2016-01-13 00:28:42]

Ooops I hit the wrong button, didn't mean to LGTM yet!

Here are my high level comments:

Thanks martijnc!

This is a reasonable approach to doing the transition, but I think it would be
simpler (less churn) to go straight to the new signature of address() and avoid
temporarily introducing address_number().

With address() returning a const IPAdddress&, address_number() can be written as
address().bytes().

Since you have already done all the work of re-writing things to
address_number(), you can switch over to this suggestion by executing these two
commands on your branch:

$ tools/git/for-all-touched-files.py -c "sed -i -e
's/address_number().empty()/address().empty()/g' [[FILENAME]]"

$ tools/git/for-all-touched-files.py -c "sed -i -e
's/address_number()/address().bytes()/g' [[FILENAME]]"


Or my suggestion phrased in other words:

  * Change
      const IPAddressNumber& IPEndpoint::address()
        to
      const IPAddress& IPEndpoint::address()

  * Now there is no need to change any locations that do
"endpoint.address().empty()", since IPAddress::empty() is defined and means the
same thing. This cuts down on some files.

  * Every other callsite of endpoint.address() would now need to be changed to
endpoint.address().bytes()


What do you think?

[commit-bot: I haz the power, 2016-01-13 00:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1565303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1565303002/40001

[eroman, 2016-01-13 00:30:26]

The CQ bit was unchecked by eroman@chromium.org

[martijnc, 2016-01-13 20:11:23]

Patchset #1 (id:20001) has been deleted

[martijnc, 2016-01-13 20:26:48]

Patchset #2 (id:80001) has been deleted

[martijnc, 2016-01-13 21:01:21]

Patchset #2 (id:100001) has been deleted

[martijnc, 2016-01-13 21:10:08]

Patchset #2 (id:120001) has been deleted

[martijnc, 2016-01-13 21:25:19]

Patchset #2 (id:140001) has been deleted

[martijnc, 2016-01-13 21:30:22]

Description was changed from

==========
Rename IPEndpoint::address() to IPEndpoint::address_number()

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress. This CL renames IPEndpoint::address() to
IPEndpoint::address_number() to make that possible. This is the first part of a
two step process:

  * Rename IPEndpoint::address() to IPEndpoint::address_number() (this CL)
  * Add IPEndpoint::address() that returns a net::IPAddress and deprecate
IPEndpoint::address_number() (follow up CL)

BUG=496258

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

to

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

[martijnc, 2016-01-13 22:49:31]

Thank you very much for your feedback!

I've updated the CL to:
  * make IPEndpoint::address() return a net::IPAddress. (had to make a couple of
changes to IPEndpoint for that, can move those to a separate CL if that's easier
to review);
  * change the IPEndpoint::address() calls to IPEndpoint::address()::bytes()
(unless it wasn't necessary). Thanks for the one-liners!

https://codereview.chromium.org/1565303002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/pepper/pepper_socket_utils.cc (right):

https://codereview.chromium.org/1565303002/diff/40001/content/browser/rendere...
content/browser/renderer_host/pepper/pepper_socket_utils.cc:184: if
(isLoopbackAddress(address.address_number())) {
On 2016/01/13 at 00:27:57, eroman wrote:
> (aside) Looks like these existing functions are incorrectly named. Filed
https://code.google.com/p/chromium/issues/detail?id=576934

(will fix that in separate CL)

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.cc
File net/base/ip_endpoint.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.c...
net/base/ip_endpoint.cc:168: return IPAddressToStringWithPort(address_.bytes(),
port_);
Would it be a good idea to add a IPAddress::ToStringWithPort(), that (for now)
would just forward the call to IPAddressToStringWithPort() (in a different CL)?

[eroman, 2016-01-13 23:19:42]

lgtm

https://codereview.chromium.org/1565303002/diff/160001/content/renderer/p2p/i...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/content/renderer/p2p/i...
content/renderer/p2p/ipc_socket_factory.cc:567:
jingle_glue::IPEndPointToSocketAddress(remote_address,
Consider remove this edit, since it is just a formatting change now.

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.cc
File net/base/ip_endpoint.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.c...
net/base/ip_endpoint.cc:162: address_ = net::IPAddress(ip_address);
There is already a constructor for this:
   address_ = net::IPAddress(address, address_len);

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.c...
net/base/ip_endpoint.cc:168: return IPAddressToStringWithPort(address_.bytes(),
port_);
On 2016/01/13 22:49:31, martijnc wrote:
> Would it be a good idea to add a IPAddress::ToStringWithPort(), that (for now)
> would just forward the call to IPAddressToStringWithPort() (in a different
CL)?

Is the pattern used in several other places? If it is just here I wouldn't worry
about it.

https://codereview.chromium.org/1565303002/diff/160001/net/dns/address_sorter...
File net/dns/address_sorter_posix.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/dns/address_sorter...
net/dns/address_sorter_posix.cc:304: if (info->address.size() ==
src.address().bytes().size()) {
Here and in several other places, you can just do address().size().

I suggest doing a search and replace through the patchset for
address().bytes().size() --> address().size()

https://codereview.chromium.org/1565303002/diff/160001/net/dns/dns_config_ser...
File net/dns/dns_config_service_posix.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/dns/dns_config_ser...
net/dns/dns_config_service_posix.cc:545: const IPAddressNumber
kEmptyAddress(kIPv4AddressSize);
Here is the zero address again we were seeing. I think IPAddress::IsZero() could
be useful.

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
net/http/http_network_transaction.cc:463: if
(!remote_endpoint_.address().bytes().size())
no change needed here per earlier comment (address().size() also exists)

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
net/http/http_network_transaction_unittest.cc:9064: EXPECT_LT(0u,
endpoint.address().bytes().size());
same here

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_connecti...
File net/quic/quic_connection.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_connecti...
net/quic/quic_connection.cc:1266: (peer_address.address().bytes() !=
peer_address_.address().bytes());
note that IPAddress already defines operator==. I suggest adding operator!= and
then no changes needed here.

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_framer_t...
File net/quic/quic_framer_test.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_framer_t...
net/quic/quic_framer_test.cc:2982:
visitor_.public_reset_packet_->client_address.address().bytes()));
Can probably do address().ToString() instead of IPAddressToString here.

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_socket_a...
File net/quic/quic_socket_address_coder.h (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_socket_a...
net/quic/quic_socket_address_coder.h:32: IPAddressNumber ip() const { return
address_.address().bytes(); }
I wonder if it is intentional that this code returns a copy instead of a const
reference?

[martijnc, 2016-01-14 21:20:39]

Patchset #3 (id:180001) has been deleted

[martijnc, 2016-01-14 21:26:43]

Patchset #3 (id:200001) has been deleted

[martijnc, 2016-01-14 22:48:16]

martijn@martijnc.be changed reviewers:
+ ben@chromium.org, jochen@chromium.org

[martijnc, 2016-01-14 22:48:17]

Thank you for the review.

+jochen@chromium.org for chrome\* and content\*

+ben@chromium.org for
    device\bluetooth\bluetooth_socket_win.cc
    extensions\browser\api\cast_channel\logger.cc
    media\cast\net\udp_transport.cc
    mojo\services\network\net_address_type_converters.cc
    remoting\host\ipc_host_event_logger.cc

Can you take a look?

https://codereview.chromium.org/1565303002/diff/160001/content/renderer/p2p/i...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/content/renderer/p2p/i...
content/renderer/p2p/ipc_socket_factory.cc:567:
jingle_glue::IPEndPointToSocketAddress(remote_address,
On 2016/01/13 at 23:19:42, eroman wrote:
> Consider remove this edit, since it is just a formatting change now.

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.cc
File net/base/ip_endpoint.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.c...
net/base/ip_endpoint.cc:162: address_ = net::IPAddress(ip_address);
On 2016/01/13 at 23:19:42, eroman wrote:
> There is already a constructor for this:
>    address_ = net::IPAddress(address, address_len);

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/base/ip_endpoint.c...
net/base/ip_endpoint.cc:168: return IPAddressToStringWithPort(address_.bytes(),
port_);
On 2016/01/13 at 23:19:42, eroman wrote:
> On 2016/01/13 22:49:31, martijnc wrote:
> > Would it be a good idea to add a IPAddress::ToStringWithPort(), that (for
now)
> > would just forward the call to IPAddressToStringWithPort() (in a different
CL)?
> 
> Is the pattern used in several other places? If it is just here I wouldn't
worry about it.

No, limited usage. I'll skip this.

https://codereview.chromium.org/1565303002/diff/160001/net/dns/address_sorter...
File net/dns/address_sorter_posix.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/dns/address_sorter...
net/dns/address_sorter_posix.cc:304: if (info->address.size() ==
src.address().bytes().size()) {
On 2016/01/13 at 23:19:42, eroman wrote:
> Here and in several other places, you can just do address().size().
> 
> I suggest doing a search and replace through the patchset for
address().bytes().size() --> address().size()

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/dns/dns_config_ser...
File net/dns/dns_config_service_posix.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/dns/dns_config_ser...
net/dns/dns_config_service_posix.cc:545: const IPAddressNumber
kEmptyAddress(kIPv4AddressSize);
On 2016/01/13 at 23:19:42, eroman wrote:
> Here is the zero address again we were seeing. I think IPAddress::IsZero()
could be useful.

Will do this in a separate CL.

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
net/http/http_network_transaction.cc:463: if
(!remote_endpoint_.address().bytes().size())
On 2016/01/13 at 23:19:42, eroman wrote:
> no change needed here per earlier comment (address().size() also exists)

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/http/http_network_...
net/http/http_network_transaction_unittest.cc:9064: EXPECT_LT(0u,
endpoint.address().bytes().size());
On 2016/01/13 at 23:19:42, eroman wrote:
> same here

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_connecti...
File net/quic/quic_connection.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_connecti...
net/quic/quic_connection.cc:1266: (peer_address.address().bytes() !=
peer_address_.address().bytes());
On 2016/01/13 at 23:19:42, eroman wrote:
> note that IPAddress already defines operator==. I suggest adding operator!=
and then no changes needed here.

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_framer_t...
File net/quic/quic_framer_test.cc (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_framer_t...
net/quic/quic_framer_test.cc:2982:
visitor_.public_reset_packet_->client_address.address().bytes()));
On 2016/01/13 at 23:19:42, eroman wrote:
> Can probably do address().ToString() instead of IPAddressToString here.

Done.

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_socket_a...
File net/quic/quic_socket_address_coder.h (right):

https://codereview.chromium.org/1565303002/diff/160001/net/quic/quic_socket_a...
net/quic/quic_socket_address_coder.h:32: IPAddressNumber ip() const { return
address_.address().bytes(); }
On 2016/01/13 at 23:19:42, eroman wrote:
> I wonder if it is intentional that this code returns a copy instead of a const
reference?

Hmm, not sure why that is. Had a quick look at the usages and I don't think
there is a need for the copy. This probably can be changed to return a const
reference without breaking things.

[jochen (gone - plz use gerrit), 2016-01-15 14:41:30]

lgtm

[martijnc, 2016-01-19 18:39:44]

Patchset #4 (id:240001) has been deleted

[martijnc, 2016-01-20 21:07:51]

martijn@martijnc.be changed reviewers:
+ miu@chromium.org, scheib@chromium.org, sky@chromium.org, wez@chromium.org
- ben@chromium.org

[martijnc, 2016-01-20 21:15:42]

+sky for mojo\services\network\net_address_type_converters.cc
+wez for remoting\host\ipc_host_event_logger.cc &
extensions\browser\api\cast_channel\logger.cc
+miu for media\cast\net\udp_transport.cc
+scheib for device\bluetooth\bluetooth_socket_win.cc

Can you take a look? Thanks!

[sky, 2016-01-20 23:06:59]

LGTM

[miu, 2016-01-21 00:57:50]

media/cast/net/udp_transport.cc lgtm % one favor:

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
media/cast/net/udp_transport.cc:185: } else if (!(remote_addr_ == recv_addr_)) {
Since you added the != operator, can you please change this expression to use
it?

[martijnc, 2016-01-21 21:15:33]

Patchset #4 (id:260001) has been deleted

[martijnc, 2016-01-21 21:16:29]

Patchset #5 (id:300001) has been deleted

[martijnc, 2016-01-21 21:28:57]

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
media/cast/net/udp_transport.cc:185: } else if (!(remote_addr_ == recv_addr_)) {
On 2016/01/21 at 00:57:50, miu wrote:
> Since you added the != operator, can you please change this expression to use
it?

remote_addr_ and recv_addr_ are net::IPEndpoint instances but the new !=
operator compares net::IPAddress instances. Using it here would ignore the port
number?

[miu, 2016-01-21 23:34:31]

LGTM

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/1565303002/diff/280001/media/cast/net/udp_tra...
media/cast/net/udp_transport.cc:185: } else if (!(remote_addr_ == recv_addr_)) {
On 2016/01/21 21:28:57, martijnc wrote:
> On 2016/01/21 at 00:57:50, miu wrote:
> > Since you added the != operator, can you please change this expression to
use
> it?
> 
> remote_addr_ and recv_addr_ are net::IPEndpoint instances but the new !=
> operator compares net::IPAddress instances. Using it here would ignore the
port
> number?

Ah, my mistake.  Never mind.

[martijnc, 2016-01-26 19:17:11]

Description was changed from

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

to

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258
TBR=scheib, wez

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

[martijnc, 2016-01-26 19:22:58]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2016-01-26 19:22:59]

TBR'ing wez and scheib.

[martijnc, 2016-01-26 19:22:59]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
jochen@chromium.org, sky@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1565303002/#ps360001
(title: "rebase for ChromeOS")

[commit-bot: I haz the power, 2016-01-26 19:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1565303002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1565303002/360001

[commit-bot: I haz the power, 2016-01-26 23:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:56:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Wez, 2016-01-27 00:08:30]

On 2016/01/26 at 19:22:59, martijn wrote:
> TBR'ing wez and scheib.

When adding multiple reviewers, please make clear what it is that you would like
them to review - thanks!

remoting/ LGTM

[eroman, 2016-01-27 00:27:45]

(Also, "git cl owners" is a useful way to generate that list)

[martijnc, 2016-01-27 07:02:37]

Description was changed from

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258
TBR=scheib, wez

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

to

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

[martijnc, 2016-01-27 07:03:46]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-01-27 07:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1565303002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1565303002/360001

[commit-bot: I haz the power, 2016-01-27 07:14:15]

Committed patchset #7 (id:360001)

[commit-bot: I haz the power, 2016-01-27 07:15:06]

Description was changed from

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
==========

to

==========
Change IPEndpoint::address() to return a net::IPAddress

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to
return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10

Committed: https://crrev.com/98acb9b5250fac2902aff41afa71496da5cf26cd
Cr-Commit-Position: refs/heads/master@{#371750}
==========

[commit-bot: I haz the power, 2016-01-27 07:15:08]

Patchset 7 (id:??) landed as
https://crrev.com/98acb9b5250fac2902aff41afa71496da5cf26cd
Cr-Commit-Position: refs/heads/master@{#371750}

[scheib, 2016-01-29 04:53:59]

device\bluetooth\bluetooth_socket_win.cc LGTM