Change IPEndpoint::address() to return a net::IPAddress

media/cast/net/udp_transport.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/net/udp_transport.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/rand_util.h"
 #include "build/build_config.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/base/rand_callback.h"
 
 namespace media {
 namespace cast {
 
 namespace {
 const int kMaxPacketSize = 1500;
 
 bool IsEmpty(const net::IPEndPoint& addr) {
-  net::IPAddressNumber empty_addr(addr.address().size());
-  return std::equal(
-             empty_addr.begin(), empty_addr.end(), addr.address().begin()) &&
+  net::IPAddressNumber empty_addr(addr.address_number().size());
+  return std::equal(empty_addr.begin(), empty_addr.end(),

[eroman, 2016/01/13 00:27:57]

I have seen this pattern in some other places. Might be worth adding a
IPAddress::IsZero() helper. Or at the very list simplifying this line to
empty_addr == addr.address.bytes().

Either way, save this for another CL if you want to do it (so we keep this
change just about the IPAddress refactor).

+                    addr.address_number().begin()) &&
          !addr.port();
 }
 
 bool IsEqual(const net::IPEndPoint& addr1, const net::IPEndPoint& addr2) {
-  return addr1.port() == addr2.port() && std::equal(addr1.address().begin(),
-                                                    addr1.address().end(),
-                                                    addr2.address().begin());
+  return addr1.port() == addr2.port() &&
+         std::equal(addr1.address_number().begin(),

[eroman, 2016/01/13 00:27:57]

Hmm, this looks wrong. Filed
https://code.google.com/p/chromium/issues/detail?id=576943

+                    addr1.address_number().end(),
+                    addr2.address_number().begin());
 }
 }  // namespace
 
 UdpTransport::UdpTransport(
     net::NetLog* net_log,
     const scoped_refptr<base::SingleThreadTaskRunner>& io_thread_proxy,
     const net::IPEndPoint& local_end_point,
     const net::IPEndPoint& remote_end_point,
     int32_t send_buffer_size,
     const CastTransportStatusCallback& status_callback)
@@ skipping 228 matching lines @@
   }
   ScheduleReceiveNextPacket();
 
   if (!cb.is_null()) {
     cb.Run();
   }
 }
 
 }  // namespace cast
 }  // namespace media