net/dns/dns_config_service_posix.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_config_service_posix.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase for ChromeOS Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_config_service_posix.cc

diff --git a/net/dns/dns_config_service_posix.cc b/net/dns/dns_config_service_posix.cc

index 31a40616b05aaccd9ebeff9368c49effc98347da..92d7dff166f2f3454f38bf221ae1f37298f017fc 100644

--- a/net/dns/dns_config_service_posix.cc

+++ b/net/dns/dns_config_service_posix.cc

@@ -544,7 +544,7 @@ ConfigParsePosixResult ConvertResStateToDnsConfig(const struct __res_state& res,

// TODO(szym): Measure how often this happens. http://crbug.com/125599

const IPAddressNumber kEmptyAddress(kIPv4AddressSize);

for (unsigned i = 0; i < dns_config->nameservers.size(); ++i) {

- if (dns_config->nameservers[i].address() == kEmptyAddress)

+ if (dns_config->nameservers[i].address().bytes() == kEmptyAddress)

return CONFIG_PARSE_POSIX_NULL_ADDRESS;

}

return CONFIG_PARSE_POSIX_OK;

« no previous file with comments | « net/dns/dns_config_service.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »