Change IPEndpoint::address() to return a net::IPAddress

net/quic/quic_socket_address_coder.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_SOCKET_ADDRESS_CODER_H_
 #define NET_QUIC_QUIC_SOCKET_ADDRESS_CODER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 11 matching lines @@
 class NET_EXPORT_PRIVATE QuicSocketAddressCoder {
  public:
   QuicSocketAddressCoder();
   explicit QuicSocketAddressCoder(const IPEndPoint& address);
   ~QuicSocketAddressCoder();
 
   std::string Encode() const;
 
   bool Decode(const char* data, size_t length);
 
-  IPAddressNumber ip() const { return address_.address(); }
+  IPAddressNumber ip() const { return address_.address().bytes(); }

[eroman, 2016/01/13 23:19:42]

I wonder if it is intentional that this code returns a copy instead of a const
reference?

[martijnc, 2016/01/14 22:48:17]

Hmm, not sure why that is. Had a quick look at the usages and I don't think
there is a need for the copy. This probably can be changed to return a const
reference without breaking things.

 
   uint16_t port() const { return address_.port(); }
 
  private:
   IPEndPoint address_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicSocketAddressCoder);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_SOCKET_ADDRESS_CODER_H_