Change IPEndpoint::address() to return a net::IPAddress

net/dns/dns_config_service_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_config_service_posix.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/file.h"
@@ skipping 524 matching lines @@
   if (res.options & kUnhandledOptions) {
     dns_config->unhandled_options = true;
     return CONFIG_PARSE_POSIX_UNHANDLED_OPTIONS;
   }
 
   if (dns_config->nameservers.empty())
     return CONFIG_PARSE_POSIX_NO_NAMESERVERS;
 
   // If any name server is 0.0.0.0, assume the configuration is invalid.
   // TODO(szym): Measure how often this happens. http://crbug.com/125599
   const IPAddressNumber kEmptyAddress(kIPv4AddressSize);

[eroman, 2016/01/13 23:19:42]

Here is the zero address again we were seeing. I think IPAddress::IsZero() could
be useful.

[martijnc, 2016/01/14 22:48:17]

Will do this in a separate CL.

   for (unsigned i = 0; i < dns_config->nameservers.size(); ++i) {
-    if (dns_config->nameservers[i].address() == kEmptyAddress)
+    if (dns_config->nameservers[i].address().bytes() == kEmptyAddress)
       return CONFIG_PARSE_POSIX_NULL_ADDRESS;
   }
   return CONFIG_PARSE_POSIX_OK;
 }
 
 #else   // defined(OS_ANDROID)
 
 bool DnsConfigServicePosix::SeenChangeSince(
     const base::Time& since_time) const {
   DCHECK(CalledOnValidThread());
@@ skipping 26 matching lines @@
 #endif  // defined(OS_ANDROID)
 
 }  // namespace internal
 
 // static
 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() {
   return scoped_ptr<DnsConfigService>(new internal::DnsConfigServicePosix());
 }
 
 }  // namespace net