Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: net/base/ip_endpoint.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase for ChromeOS Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ip_endpoint.h ('k') | net/base/ip_endpoint_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ip_endpoint.cc
diff --git a/net/base/ip_endpoint.cc b/net/base/ip_endpoint.cc
index c88ae2ec723efa062e7722f39b0c6ebbe8ee6677..df0cb56947f1fd9159fdab3f44721dd4470ca0d8 100644
--- a/net/base/ip_endpoint.cc
+++ b/net/base/ip_endpoint.cc
@@ -89,8 +89,7 @@ IPEndPoint::IPEndPoint(const IPAddressNumber& address, uint16_t port)
}
IPEndPoint::IPEndPoint(const IPAddress& address, uint16_t port)
- : address_(address.bytes()), port_(port) {
-}
+ : address_(address), port_(port) {}
IPEndPoint::IPEndPoint(const IPEndPoint& endpoint) {
address_ = endpoint.address_;
@@ -98,7 +97,7 @@ IPEndPoint::IPEndPoint(const IPEndPoint& endpoint) {
}
AddressFamily IPEndPoint::GetFamily() const {
- return GetAddressFamily(address_);
+ return GetAddressFamily(address_.bytes());
}
int IPEndPoint::GetSockAddrFamily() const {
@@ -126,7 +125,7 @@ bool IPEndPoint::ToSockAddr(struct sockaddr* address,
memset(addr, 0, sizeof(struct sockaddr_in));
addr->sin_family = AF_INET;
addr->sin_port = base::HostToNet16(port_);
- memcpy(&addr->sin_addr, &address_[0], kIPv4AddressSize);
+ memcpy(&addr->sin_addr, &address_.bytes()[0], kIPv4AddressSize);
break;
}
case kIPv6AddressSize: {
@@ -138,7 +137,7 @@ bool IPEndPoint::ToSockAddr(struct sockaddr* address,
memset(addr6, 0, sizeof(struct sockaddr_in6));
addr6->sin6_family = AF_INET6;
addr6->sin6_port = base::HostToNet16(port_);
- memcpy(&addr6->sin6_addr, &address_[0], kIPv6AddressSize);
+ memcpy(&addr6->sin6_addr, &address_.bytes()[0], kIPv6AddressSize);
break;
}
default:
@@ -159,17 +158,17 @@ bool IPEndPoint::FromSockAddr(const struct sockaddr* sock_addr,
return false;
}
- address_.assign(address, address + address_len);
+ address_ = net::IPAddress(address, address_len);
port_ = port;
return true;
}
std::string IPEndPoint::ToString() const {
- return IPAddressToStringWithPort(address_, port_);
+ return IPAddressToStringWithPort(address_.bytes(), port_);
}
std::string IPEndPoint::ToStringWithoutPort() const {
- return IPAddressToString(address_);
+ return address_.ToString();
}
bool IPEndPoint::operator<(const IPEndPoint& other) const {
« no previous file with comments | « net/base/ip_endpoint.h ('k') | net/base/ip_endpoint_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698