Use std::move() instead of .Pass() in remoting/host

Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.

Committed: https://crrev.com/1417e013d741b99685fee8f3d3c166f597655eda
Cr-Commit-Position: refs/heads/master@{#366759}

[Sergey Ulanov, 2015-12-22 17:47:03]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[dcheng, 2015-12-22 17:48:19]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-12-22 17:48:20]

https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
File remoting/host/audio_capturer_linux.cc (right):

https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
remoting/host/audio_capturer_linux.cc:67: callback_.Run(std::move(packet));
Don't forget to #include <utility> where appropriate.

[Sergey Ulanov, 2015-12-22 18:03:11]

Description was changed from

==========
Used std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
==========

to

==========
Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
==========

[Sergey Ulanov, 2015-12-22 18:11:03]

https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
File remoting/host/audio_capturer_linux.cc (right):

https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
remoting/host/audio_capturer_linux.cc:67: callback_.Run(std::move(packet));
On 2015/12/22 17:48:20, dcheng wrote:
> Don't forget to #include <utility> where appropriate.

scoped_ptr.h includes <utility> already, so I don't think it's necessary to
include it explicitly. At least not until we switch to std::unique_ptr<>

[dcheng, 2015-12-22 18:26:24]

On 2015/12/22 at 18:11:03, sergeyu wrote:
>
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> File remoting/host/audio_capturer_linux.cc (right):
> 
>
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> remoting/host/audio_capturer_linux.cc:67: callback_.Run(std::move(packet));
> On 2015/12/22 17:48:20, dcheng wrote:
> > Don't forget to #include <utility> where appropriate.
> 
> scoped_ptr.h includes <utility> already, so I don't think it's necessary to
include it explicitly. At least not until we switch to std::unique_ptr<>

<memory> does not though, and forgetting to #include it now will make scoped_ptr
-> std::unique_ptr harder since a lot of IWYU violations will need to be fixed.

[Sergey Ulanov, 2015-12-23 02:40:01]

On 2015/12/22 18:26:24, dcheng wrote:
> On 2015/12/22 at 18:11:03, sergeyu wrote:
> >
>
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> > File remoting/host/audio_capturer_linux.cc (right):
> > 
> >
>
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> > remoting/host/audio_capturer_linux.cc:67: callback_.Run(std::move(packet));
> > On 2015/12/22 17:48:20, dcheng wrote:
> > > Don't forget to #include <utility> where appropriate.
> > 
> > scoped_ptr.h includes <utility> already, so I don't think it's necessary to
> include it explicitly. At least not until we switch to std::unique_ptr<>
> 
> <memory> does not though, and forgetting to #include it now will make
scoped_ptr
> -> std::unique_ptr harder since a lot of IWYU violations will need to be
fixed.

I don't think it would be more difficult to add that #include later compared to
doing it now.
Anyway added #include <utility> in the latest patchset. PTAL. Will make another
CL to add it
in remoting/protocol - which I already converted to std::move.

[dcheng, 2015-12-23 02:45:05]

On 2015/12/23 at 02:40:01, sergeyu wrote:
> On 2015/12/22 18:26:24, dcheng wrote:
> > On 2015/12/22 at 18:11:03, sergeyu wrote:
> > >
> >
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> > > File remoting/host/audio_capturer_linux.cc (right):
> > > 
> > >
> >
https://codereview.chromium.org/1549493004/diff/20001/remoting/host/audio_cap...
> > > remoting/host/audio_capturer_linux.cc:67:
callback_.Run(std::move(packet));
> > > On 2015/12/22 17:48:20, dcheng wrote:
> > > > Don't forget to #include <utility> where appropriate.
> > > 
> > > scoped_ptr.h includes <utility> already, so I don't think it's necessary
to
> > include it explicitly. At least not until we switch to std::unique_ptr<>
> > 
> > <memory> does not though, and forgetting to #include it now will make
scoped_ptr
> > -> std::unique_ptr harder since a lot of IWYU violations will need to be
fixed.
> 
> I don't think it would be more difficult to add that #include later compared
to doing it now.
> Anyway added #include <utility> in the latest patchset. PTAL. Will make
another CL to add it
> in remoting/protocol - which I already converted to std::move.

Thanks =) For me, it does make a difference: adding it proactively keeps random
targets from failing when we do the transition. It's true that individual
instances aren't hard to fix, but the costs do add up across the entire
codebase, especially if hundreds of compilation units do this incorrectly.

[Jamie, 2015-12-23 13:48:38]

lgtm

[Sergey Ulanov, 2015-12-23 18:33:02]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-12-23 18:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549493004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549493004/40001

[commit-bot: I haz the power, 2015-12-23 19:01:29]

Description was changed from

==========
Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
==========

to

==========
Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
==========

[commit-bot: I haz the power, 2015-12-23 19:01:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-23 19:02:43]

Description was changed from

==========
Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
==========

to

==========
Use std::move() instead of .Pass() in remoting/host

Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.

Committed: https://crrev.com/1417e013d741b99685fee8f3d3c166f597655eda
Cr-Commit-Position: refs/heads/master@{#366759}
==========

[commit-bot: I haz the power, 2015-12-23 19:02:44]

Patchset 3 (id:??) landed as
https://crrev.com/1417e013d741b99685fee8f3d3c166f597655eda
Cr-Commit-Position: refs/heads/master@{#366759}