remoting/host/native_messaging/log_message_handler.cc - Issue 1549493004: Use std::move() instead of .Pass() in remoting/host

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/native_messaging/log_message_handler.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass

Patch Set: include <utility> Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « remoting/host/mouse_shape_pump_unittest.cc ('k') | remoting/host/native_messaging/native_messaging_pipe.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/host/native_messaging/log_message_handler.h"	5 #include "remoting/host/native_messaging/log_message_handler.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/lazy_instance.h"	8 #include "base/lazy_instance.h"

9 #include "base/strings/string_util.h"	9 #include "base/strings/string_util.h"

10 #include "base/synchronization/lock.h"	10 #include "base/synchronization/lock.h"

(...skipping 106 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
117 std::string message = str.substr(message_start);	117 std::string message = str.substr(message_start);

118 base::TrimWhitespaceASCII(message, base::TRIM_ALL, &message);	118 base::TrimWhitespaceASCII(message, base::TRIM_ALL, &message);

119	119

120 scoped_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);	120 scoped_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);

121 dictionary->SetString("type", kDebugMessageTypeName);	121 dictionary->SetString("type", kDebugMessageTypeName);

122 dictionary->SetString("severity", severity_string);	122 dictionary->SetString("severity", severity_string);

123 dictionary->SetString("message", message);	123 dictionary->SetString("message", message);

124 dictionary->SetString("file", file);	124 dictionary->SetString("file", file);

125 dictionary->SetInteger("line", line);	125 dictionary->SetInteger("line", line);

126	126

127 delegate_.Run(dictionary.Pass());	127 delegate_.Run(std::move(dictionary));

128	128

129 suppress_logging_ = false;	129 suppress_logging_ = false;

130 }	130 }

131	131

132 } // namespace remoting	132 } // namespace remoting

OLD	NEW