remoting/host/chromeos/clipboard_aura.cc - Issue 1549493004: Use std::move() instead of .Pass() in remoting/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/chromeos/clipboard_aura.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass

Patch Set: include <utility> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/chromeos/aura_desktop_capturer_unittest.cc ('k') | remoting/host/chromeos/mouse_cursor_monitor_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/chromeos/clipboard_aura.cc

diff --git a/remoting/host/chromeos/clipboard_aura.cc b/remoting/host/chromeos/clipboard_aura.cc

index 3933c95cd16de86fc6c4951c7fa6b73ea40424b5..ef0438b96838ccc77a2e41814e618fa29ab3979c 100644

--- a/remoting/host/chromeos/clipboard_aura.cc

+++ b/remoting/host/chromeos/clipboard_aura.cc

@@ -4,6 +4,8 @@

#include "remoting/host/chromeos/clipboard_aura.h"

+#include <utility>

#include "base/strings/utf_string_conversions.h"

#include "remoting/base/constants.h"

#include "remoting/proto/event.pb.h"

@@ -33,7 +35,7 @@ void ClipboardAura::Start(

scoped_ptr<protocol::ClipboardStub> client_clipboard) {

DCHECK(thread_checker_.CalledOnValidThread());

- client_clipboard_ = client_clipboard.Pass();

+ client_clipboard_ = std::move(client_clipboard);

// Aura doesn't provide a clipboard-changed notification. The only way to

// detect clipboard changes is by polling.

« no previous file with comments | « remoting/host/chromeos/aura_desktop_capturer_unittest.cc ('k') | remoting/host/chromeos/mouse_cursor_monitor_aura.cc » ('j') | no next file with comments »