Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1545723002: Use std::move() instead of .Pass() in remoting/* (Closed)

Created:
5 years ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_not_pass_host
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::move() instead of .Pass() in remoting/* Now there is a presubmit check that doesn't allow Pass() anymore. See https://www.chromium.org/rvalue-references for information about std::move in chromium. Committed: https://crrev.com/42ad7c02c6aacbd7e8427cc062de5b6c4d596e5a Cr-Commit-Position: refs/heads/master@{#366778}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -203 lines) Patch
M remoting/base/auto_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/buffered_socket_writer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/base/rsa_key_pair.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M remoting/base/typed_buffer_unittest.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M remoting/base/url_request_context_getter.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/client/audio_decode_scheduler.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M remoting/client/audio_player_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/chromoting_client.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M remoting/client/chromoting_client.cc View 1 2 5 chunks +12 lines, -5 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 2 18 chunks +28 lines, -28 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.cc View 1 2 3 chunks +7 lines, -10 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M remoting/client/server_log_entry_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/software_video_renderer.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M remoting/client/software_video_renderer_unittest.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/codec/audio_decoder_opus.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M remoting/codec/audio_decoder_verbatim.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M remoting/codec/audio_encoder_opus.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/audio_encoder_opus_unittest.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M remoting/codec/audio_encoder_verbatim.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/codec_test.cc View 1 2 6 chunks +7 lines, -9 lines 0 comments Download
M remoting/codec/video_encoder_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_verbatim.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/codec/video_encoder_vpx_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/signaling/iq_sender.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M remoting/signaling/iq_sender_unittest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M remoting/signaling/jingle_info_request.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/signaling/log_to_server.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M remoting/signaling/server_log_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/xmpp_login_handler.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/signaling/xmpp_login_handler_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy_unittest.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_stream_parser_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/test/app_remoting_connected_client_fixture.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/test/app_remoting_connection_helper.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M remoting/test/app_remoting_latency_test_fixture.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/test/app_remoting_test_driver_environment_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M remoting/test/mock_access_token_fetcher.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 8 chunks +14 lines, -16 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 1 2 6 chunks +10 lines, -12 lines 0 comments Download
M remoting/test/test_video_renderer_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
Sergey Ulanov
5 years ago (2015-12-22 18:11:48 UTC) #2
kelvinp
lgtm
5 years ago (2015-12-23 02:09:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545723002/40001
5 years ago (2015-12-23 22:50:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/139747)
5 years ago (2015-12-23 23:04:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545723002/60001
5 years ago (2015-12-23 23:09:41 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-24 00:21:00 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-24 00:22:44 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/42ad7c02c6aacbd7e8427cc062de5b6c4d596e5a
Cr-Commit-Position: refs/heads/master@{#366778}

Powered by Google App Engine
This is Rietveld 408576698