remoting/host/native_messaging/native_messaging_writer_unittest.cc - Issue 1549493004: Use std::move() instead of .Pass() in remoting/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/native_messaging/native_messaging_writer_unittest.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass

Patch Set: include <utility> Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/native_messaging/native_messaging_writer.cc ('k') | remoting/host/native_messaging/pipe_messaging_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/native_messaging/native_messaging_writer_unittest.cc

diff --git a/remoting/host/native_messaging/native_messaging_writer_unittest.cc b/remoting/host/native_messaging/native_messaging_writer_unittest.cc

index 88dbb2147b0de52666a0ead4e2cc1218d62bd202..def0a757365681a746b6e61e2110d0e6139d6101 100644

--- a/remoting/host/native_messaging/native_messaging_writer_unittest.cc

+++ b/remoting/host/native_messaging/native_messaging_writer_unittest.cc

@@ -6,6 +6,8 @@

#include <stdint.h>

+#include <utility>

#include "base/json/json_reader.h"

#include "base/memory/scoped_ptr.h"

#include "base/stl_util.h"

@@ -29,12 +31,11 @@ class NativeMessagingWriterTest : public testing::Test {

};

NativeMessagingWriterTest::NativeMessagingWriterTest() {}

NativeMessagingWriterTest::~NativeMessagingWriterTest() {}

void NativeMessagingWriterTest::SetUp() {

ASSERT_TRUE(MakePipe(&read_file_, &write_file_));

- writer_.reset(new NativeMessagingWriter(write_file_.Pass()));

+ writer_.reset(new NativeMessagingWriter(std::move(write_file_)));

}

TEST_F(NativeMessagingWriterTest, GoodMessage) {