Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: remoting/host/gcd_rest_client_unittest.cc

Issue 1549493004: Use std::move() instead of .Pass() in remoting/host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_not_pass
Patch Set: include <utility> Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/gcd_rest_client.cc ('k') | remoting/host/gcd_state_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/gcd_rest_client_unittest.cc
diff --git a/remoting/host/gcd_rest_client_unittest.cc b/remoting/host/gcd_rest_client_unittest.cc
index 9e6195092d3c5be024d41f59444d1eff970de32d..cfdbd9e6f6e3dfc7015cdcc6199530f78c6f2670 100644
--- a/remoting/host/gcd_rest_client_unittest.cc
+++ b/remoting/host/gcd_rest_client_unittest.cc
@@ -28,7 +28,7 @@ class GcdRestClientTest : public testing::Test {
scoped_ptr<base::DictionaryValue> MakePatchDetails(int id) {
scoped_ptr<base::DictionaryValue> patch_details(new base::DictionaryValue);
patch_details->SetInteger("id", id);
- return patch_details.Pass();
+ return patch_details;
}
void CreateClient(OAuthTokenGetter* token_getter = nullptr) {
@@ -55,7 +55,7 @@ TEST_F(GcdRestClientTest, NetworkErrorGettingToken) {
FakeOAuthTokenGetter token_getter(OAuthTokenGetter::NETWORK_ERROR, "", "");
CreateClient(&token_getter);
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
base::RunLoop().RunUntilIdle();
@@ -68,7 +68,7 @@ TEST_F(GcdRestClientTest, AuthErrorGettingToken) {
FakeOAuthTokenGetter token_getter(OAuthTokenGetter::AUTH_ERROR, "", "");
CreateClient(&token_getter);
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
base::RunLoop().RunUntilIdle();
@@ -80,7 +80,7 @@ TEST_F(GcdRestClientTest, AuthErrorGettingToken) {
TEST_F(GcdRestClientTest, NetworkErrorOnPost) {
CreateClient();
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
@@ -97,7 +97,7 @@ TEST_F(GcdRestClientTest, NetworkErrorOnPost) {
TEST_F(GcdRestClientTest, OtherErrorOnPost) {
CreateClient();
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
@@ -114,7 +114,7 @@ TEST_F(GcdRestClientTest, OtherErrorOnPost) {
TEST_F(GcdRestClientTest, NoSuchHost) {
CreateClient();
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
@@ -131,7 +131,7 @@ TEST_F(GcdRestClientTest, NoSuchHost) {
TEST_F(GcdRestClientTest, Succeed) {
CreateClient();
- client_->PatchState(MakePatchDetails(0).Pass(),
+ client_->PatchState(MakePatchDetails(0),
base::Bind(&GcdRestClientTest::OnRequestComplete,
base::Unretained(this)));
net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
« no previous file with comments | « remoting/host/gcd_rest_client.cc ('k') | remoting/host/gcd_state_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698