Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1548273002:
Remove Pass() on Linux. (Closed)
DescriptionRemove Pass() on Linux.
Pass() is a legacy of the original C++03 move emulation implementation.
New code should use std::move from <utility>. ChromeOS is exempt until the
migration there is complete.
❆(੭ु ◜◡‾)੭ु⁾☃❆
BUG=557422
R=thestig@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/f1f3cb1d493ee39adc82089c8eb6966777c8f6ff
Patch Set 1 #Patch Set 2 : Exclude Android and CrOS for now #Patch Set 3 : Android and Linux #Patch Set 4 : Revert Android for now #Messages
Total messages: 37 (21 generated)
This is currently blocked on 4 CLs: - https://codereview.chromium.org/1551553002 - https://codereview.chromium.org/1550733002 - https://codereview.chromium.org/1549353002 - https://codereview.chromium.org/1549363002 After this is ChromeOS, Android, Mac, Windows, and finally iOS (since this involves a bunch of changes to a private repo too).
thestig@chromium.org changed reviewers: + thestig@chromium.org
lgtm
Description was changed from ========== Remove Pass() if OS==linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=danakj@chromium.org ========== to ========== Remove Pass() for OS=linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=danakj@chromium.org ==========
Description was changed from ========== Remove Pass() for OS=linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=danakj@chromium.org ========== to ========== Remove Pass() for OS=linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Description was changed from ========== Remove Pass() for OS=linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Linux. Android and CrOS are exempted for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
The CQ bit was checked by dcheng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/1548273002/#ps20001 (title: "Exclude Android and CrOS for now")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Description was changed from ========== Remove Pass() on Linux. Android and CrOS are exempted for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Android and Linux. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
PTAL. I ended up having to fix a bunch of Android issues too, so I ended up rolling OS_ANDROID into this patch too.
still lgtm
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548273002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548273002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
(Abandoning the Android part of this for now.... grrr)
Description was changed from ========== Remove Pass() on Android and Linux. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Linux. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
The CQ bit was checked by dcheng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/1548273002/#ps60001 (title: "Revert Android for now")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548273002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548273002/60001
Description was changed from ========== Remove Pass() on Linux. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. Instead, use std::move from <utility>. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
Description was changed from ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. Instead, use std::move from <utility>. ChromeOS is exempt for now. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ChromeOS is exempt until the migration there is complete. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ==========
Message was sent while issue was closed.
Description was changed from ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ChromeOS is exempt until the migration there is complete. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org ========== to ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ChromeOS is exempt until the migration there is complete. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org Committed: https://crrev.com/f1f3cb1d493ee39adc82089c8eb6966777c8f6ff Cr-Commit-Position: refs/heads/master@{#367177} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f1f3cb1d493ee39adc82089c8eb6966777c8f6ff Cr-Commit-Position: refs/heads/master@{#367177}
Message was sent while issue was closed.
Description was changed from ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ChromeOS is exempt until the migration there is complete. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org Committed: https://crrev.com/f1f3cb1d493ee39adc82089c8eb6966777c8f6ff Cr-Commit-Position: refs/heads/master@{#367177} ========== to ========== Remove Pass() on Linux. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ChromeOS is exempt until the migration there is complete. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f1f3cb1d493ee39adc82089c8eb6... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as f1f3cb1d493ee39adc82089c8eb6966777c8f6ff (presubmit successful). |
