Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549363002: Convert Pass()→std::move() in generated devtools protocol handler. (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in generated devtools protocol handler. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=dgozman@chromium.org Committed: https://crrev.com/9225f5b8a7e03f06ccdc51ac7daf5e0349c603ee Cr-Commit-Position: refs/heads/master@{#366979}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 4 chunks +5 lines, -3 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +dgozman as fyi
4 years, 12 months ago (2015-12-28 07:01:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549363002/1
4 years, 12 months ago (2015-12-28 07:02:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 08:04:58 UTC) #5
Avi (use Gerrit)
lgtm https://codereview.chromium.org/1549363002/diff/1/content/browser/devtools/protocol/devtools_protocol_handler_generator.py File content/browser/devtools/protocol/devtools_protocol_handler_generator.py (right): https://codereview.chromium.org/1549363002/diff/1/content/browser/devtools/protocol/devtools_protocol_handler_generator.py#newcode426 content/browser/devtools/protocol/devtools_protocol_handler_generator.py:426: params->ToValue()); wrap back to previous line?
4 years, 12 months ago (2015-12-28 15:00:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549363002/1
4 years, 12 months ago (2015-12-28 16:02:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 16:06:48 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 16:08:06 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9225f5b8a7e03f06ccdc51ac7daf5e0349c603ee
Cr-Commit-Position: refs/heads/master@{#366979}

Powered by Google App Engine
This is Rietveld 408576698