Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1549353002: Convert Pass()→std::move() in generated JS schema bindings. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in generated JS schema bindings. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=rdevlin.cronin@chromium.org Committed: https://crrev.com/832f2f92f4b557e884bf2df30b3e500a0ef39737 Cr-Commit-Position: refs/heads/master@{#366978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 8 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dcheng
+avi for general review/sanity check +rdevlin.cronin for owners stamp
4 years, 11 months ago (2015-12-28 06:59:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549353002/1
4 years, 11 months ago (2015-12-28 06:59:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-28 08:09:13 UTC) #5
Avi (use Gerrit)
lgtm
4 years, 11 months ago (2015-12-28 15:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549353002/1
4 years, 11 months ago (2015-12-28 16:02:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 16:06:34 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/832f2f92f4b557e884bf2df30b3e500a0ef39737 Cr-Commit-Position: refs/heads/master@{#366978}
4 years, 11 months ago (2015-12-28 16:08:04 UTC) #12
Devlin
4 years, 11 months ago (2015-12-28 17:16:16 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698