Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: base/memory/scoped_ptr_unittest.cc

Issue 1548273002: Remove Pass() on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert Android for now Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/move.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/scoped_ptr_unittest.cc
diff --git a/base/memory/scoped_ptr_unittest.cc b/base/memory/scoped_ptr_unittest.cc
index 6022293475118fbc980740dc8b8ed14b4a5be8c7..24d43c53a966feb89bb4ae5f83b9beaeb5e273d7 100644
--- a/base/memory/scoped_ptr_unittest.cc
+++ b/base/memory/scoped_ptr_unittest.cc
@@ -11,6 +11,7 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/macros.h"
+#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -401,6 +402,7 @@ TEST(ScopedPtrTest, MoveBehavior) {
EXPECT_TRUE(scoper3.get());
}
+#if !(defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Test uncaught Pass() does not have side effects, because Pass()
// is implemented by std::move().
// TODO(danakj): Remove this test case when we remove Pass().
@@ -416,6 +418,7 @@ TEST(ScopedPtrTest, MoveBehavior) {
EXPECT_TRUE(rvalue);
}
EXPECT_EQ(0, constructed);
+#endif
// Test that passing to function which does nothing does not leak.
{
« no previous file with comments | « no previous file | base/move.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698