Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1551553002: Remove DOM Distiller dependency on scoped_ptr<T>::Pass(). (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
Base URL:
https://github.com/chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove DOM Distiller dependency on scoped_ptr<T>::Pass(). BUG=557422 R=avi@chromium.org, wychen@chromium.org Committed: 349b932fc23a37afc67bc0eb3da6f7c48ed7e035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M protoc_plugins/json_values_converter.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
4 years, 12 months ago (2015-12-28 06:50:47 UTC) #3
dcheng
+avi can you take a look? Hopefully that will still be enough to let me ...
4 years, 12 months ago (2015-12-28 18:40:26 UTC) #5
Avi (use Gerrit)
lgtm Looks reasonable. Good luck.
4 years, 12 months ago (2015-12-28 18:41:45 UTC) #6
wychen
lgtm
4 years, 12 months ago (2015-12-28 22:55:10 UTC) #7
wychen
4 years, 12 months ago (2015-12-28 22:56:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
349b932fc23a37afc67bc0eb3da6f7c48ed7e035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698