Issue 1550733002: Convert Pass()→std::move() in generated Mojo bindings.

Issue 1550733002: Convert Pass()→std::move() in generated Mojo bindings. (Closed)

Created:
4 years, 12 months ago by dcheng

Modified:
4 years, 12 months ago

Reviewers:
Avi (use Gerrit), yzshen1

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert Pass()→std::move() in generated Mojo bindings. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=yzshen@chromium.org Committed: https://crrev.com/3584b722197d3ed083bd3805011569d5093a9971 Cr-Commit-Position: refs/heads/master@{#366980}

Patch Set 1 #

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -12 lines)			Patch
M	mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 12 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dcheng

+avi for general review / sanity check +yzshen for owners stamp

4 years, 12 months ago (2015-12-28 06:56:27 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550733002/1

4 years, 12 months ago (2015-12-28 06:56:41 UTC) #4

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 12 months ago (2015-12-28 08:03:28 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550733002/1

4 years, 12 months ago (2015-12-28 16:02:36 UTC) #9

commit-bot: I haz the power

4 years, 12 months ago (2015-12-28 16:09:09 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3584b722197d3ed083bd3805011569d5093a9971
Cr-Commit-Position: refs/heads/master@{#366980}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages