Reland of Change extension icon load errors to warnings

Reland of Change extension icon load errors to warnings (patchset #2 id:300001 of https://codereview.chromium.org/1554583002/ )

Reason for revert:
this revert managed to break the tree

Original issue's description:
> Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ )
>
> Reason for revert:
> file read from wrong thread
>
> Original issue's description:
> > Change extension icon load errors to warnings
> >
> > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary.
> >
> > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake.
> >
> > BUG=570249
> >
> > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> > Cr-Commit-Position: refs/heads/master@{#366253}
>
> TBR=rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=570249
>
> Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
> Cr-Commit-Position: refs/heads/master@{#367080}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
Committed: https://crrev.com/82eaf58a99fb2cfd7c482ee301d57e00508a903a
Cr-Commit-Position: refs/heads/master@{#367081}

[Evan Stade, 2015-12-29 17:50:15]

Created Reland of Change extension icon load errors to warnings

[commit-bot: I haz the power, 2015-12-29 17:50:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547413002/1

[commit-bot: I haz the power, 2015-12-29 17:51:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-29 17:52:16]

Description was changed from

==========
Reland of Change extension icon load errors to warnings (patchset #2 id:300001
of https://codereview.chromium.org/1554583002/ )

Reason for revert:
this revert managed to break the tree

Original issue's description:
> Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )
> 
> Reason for revert:
> file read from wrong thread
> 
> Original issue's description:
> > Change extension icon load errors to warnings
> >
> > During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> >
> > Keep the same check during the validation phase and don't apply the
workaround to unpacked extensions. This will more strongly discourage new
extensions from making this mistake.
> >
> > BUG=570249
> >
> > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> > Cr-Commit-Position: refs/heads/master@{#366253}
> 
> TBR=rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=570249
> 
> Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
> Cr-Commit-Position: refs/heads/master@{#367080}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
==========

to

==========
Reland of Change extension icon load errors to warnings (patchset #2 id:300001
of https://codereview.chromium.org/1554583002/ )

Reason for revert:
this revert managed to break the tree

Original issue's description:
> Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )
>
> Reason for revert:
> file read from wrong thread
>
> Original issue's description:
> > Change extension icon load errors to warnings
> >
> > During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> >
> > Keep the same check during the validation phase and don't apply the
workaround to unpacked extensions. This will more strongly discourage new
extensions from making this mistake.
> >
> > BUG=570249
> >
> > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> > Cr-Commit-Position: refs/heads/master@{#366253}
>
> TBR=rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=570249
>
> Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
> Cr-Commit-Position: refs/heads/master@{#367080}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Committed: https://crrev.com/82eaf58a99fb2cfd7c482ee301d57e00508a903a
Cr-Commit-Position: refs/heads/master@{#367081}
==========

[commit-bot: I haz the power, 2015-12-29 17:52:16]

Patchset 1 (id:??) landed as
https://crrev.com/82eaf58a99fb2cfd7c482ee301d57e00508a903a
Cr-Commit-Position: refs/heads/master@{#367081}

[Lei Zhang, 2015-12-29 19:48:39]

https://codereview.chromium.org/1547413002/diff/1/extensions/common/file_util.cc
File extensions/common/file_util.cc (left):

https://codereview.chromium.org/1547413002/diff/1/extensions/common/file_util...
extensions/common/file_util.cc:61: int64 size = 0;
avi@ got rid of base/basictypes.h, see chromium-dev PSA.