Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: chrome/browser/extensions/extension_service_test_with_install.cc

Issue 1547413002: Reland of Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_test_with_install.cc
diff --git a/chrome/browser/extensions/extension_service_test_with_install.cc b/chrome/browser/extensions/extension_service_test_with_install.cc
index f2cedefa8b00ba423727e93b41862fef9b5c8612..8f93b2c52f0fea69424f7290738bbe100d332a05 100644
--- a/chrome/browser/extensions/extension_service_test_with_install.cc
+++ b/chrome/browser/extensions/extension_service_test_with_install.cc
@@ -124,6 +124,20 @@
InstallState install_state) {
return PackAndInstallCRX(dir_path, base::FilePath(), install_state,
Extension::NO_FLAGS);
+}
+
+const Extension* ExtensionServiceTestWithInstall::PackAndInstallCRXWithLocation(
+ const base::FilePath& dir_path,
+ Manifest::Location location,
+ InstallState install_state) {
+ // TODO(devlin): reuse another function instead of reimplementing here.
+ base::FilePath crx_path;
+ base::ScopedTempDir temp_dir;
+ EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
+ crx_path = temp_dir.path().AppendASCII("temp.crx");
+
+ PackCRX(dir_path, base::FilePath(), crx_path);
+ return InstallCRXWithLocation(crx_path, location, install_state);
}
// Attempts to install an extension. Use INSTALL_FAILED if the installation

Powered by Google App Engine
This is Rietveld 408576698