extensions/common/manifest_handlers/icons_handler.cc - Issue 1547413002: Reland of Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/icons_handler.cc

Issue 1547413002: Reland of Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_handlers/icons_handler.cc

diff --git a/extensions/common/manifest_handlers/icons_handler.cc b/extensions/common/manifest_handlers/icons_handler.cc

index 20ad025b25ba879eaeb8dab1f3d86f4ceef92bc4..52597e5b621327320b950aa84cb00d919ff3964c 100644

--- a/extensions/common/manifest_handlers/icons_handler.cc

+++ b/extensions/common/manifest_handlers/icons_handler.cc

@@ -64,7 +64,7 @@

}

if (!manifest_handler_helpers::LoadIconsFromDictionary(

- icons_dict, &icons_info->icons, error)) {

+ extension, icons_dict, &icons_info->icons, error)) {

return false;

}

« extensions/common/file_util.cc ('K') | « extensions/common/manifest_handler_helpers.cc ('k') | extensions/test/data/file_util/bad_icon/manifest.json » ('j') | no next file with comments »