Reland of Change extension icon load errors to warnings

chrome/browser/extensions/extension_action_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_action_manager.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 66 matching lines @@
   std::string id = base::IntToString(curr_id_++);
   scoped_refptr<Extension> extension =
       ExtensionBuilder()
           .SetManifest(std::move(
               DictionaryBuilder()
                   .Set("version", "1")
                   .Set("manifest_version", 2)
                   .Set("icons", std::move(extension_icons))
                   .Set(action_type, std::move(action))
                   .Set("name", std::string("Test Extension").append(id))))
+          .SetLocation(Manifest::UNPACKED)
           .SetID(id)
           .Build();
   registry_->AddEnabled(extension);
   return extension;
 }
 
 bool ExtensionActionManagerTest::TitlesMatch(const Extension& extension,
                                              const ExtensionAction& action) {
   return action.GetTitle(ExtensionAction::kDefaultTabId) == extension.name();
 }
@@ skipping 124 matching lines @@
       manager()->GetBestFitAction(*extension.get(), ActionInfo::TYPE_BROWSER);
 
   // Now these values match because |extension| does not have page action
   // defaults.
   ASSERT_TRUE(TitlesMatch(*extension.get(), *action));
   ASSERT_TRUE(IconsMatch(*extension.get(), 48, *action, 38));
 }
 
 }  // namespace
 }  // namespace extensions