Reland of Change extension icon load errors to warnings

extensions/common/manifest_handlers/icons_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/icons_handler.h"
 
 #include "base/files/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 46 matching lines @@
 
 bool IconsHandler::Parse(Extension* extension, base::string16* error) {
   scoped_ptr<IconsInfo> icons_info(new IconsInfo);
   const base::DictionaryValue* icons_dict = NULL;
   if (!extension->manifest()->GetDictionary(keys::kIcons, &icons_dict)) {
     *error = base::ASCIIToUTF16(manifest_errors::kInvalidIcons);
     return false;
   }
 
   if (!manifest_handler_helpers::LoadIconsFromDictionary(
-          icons_dict, &icons_info->icons, error)) {
+          extension, icons_dict, &icons_info->icons, error)) {
     return false;
   }
 
   extension->SetManifestData(keys::kIcons, icons_info.release());
   return true;
 }
 
 bool IconsHandler::Validate(const Extension* extension,
                             std::string* error,
                             std::vector<InstallWarning>* warnings) const {
   return file_util::ValidateExtensionIconSet(IconsInfo::GetIcons(extension),
                                              extension,
                                              IDS_EXTENSION_LOAD_ICON_FAILED,
                                              error);
 }
 
 const std::vector<std::string> IconsHandler::Keys() const {
   return SingleKey(keys::kIcons);
 }
 
 }  // namespace extensions