Reland of Change extension icon load errors to warnings

chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
@@ skipping 68 matching lines @@
                   .Set("name", "Dictionary default icon")
                   .Set("version", "1.0.0")
                   .Set("manifest_version", 2)
                   .Set("browser_action",
                        std::move(DictionaryBuilder().Set(
                            "default_icon",
                            std::move(DictionaryBuilder()
                                          .Set("19", "icon19.png")
                                          .Set("24", "icon24.png")
                                          .Set("38", "icon38.png")))))))
+          // Don't check for existence of icons during parsing.
+          .SetLocation(Manifest::UNPACKED)
           .Build();
 
   ASSERT_TRUE(extension.get());
   const ActionInfo* browser_action_info =
       ActionInfo::GetBrowserActionInfo(extension.get());
   ASSERT_TRUE(browser_action_info);
   ASSERT_FALSE(browser_action_info->default_icon.empty());
 
   const ExtensionIconSet& icons = browser_action_info->default_icon;
 
@@ skipping 22 matching lines @@
 
   base::string16 error = ErrorUtils::FormatErrorMessageUTF16(
       errors::kInvalidIconPath, "19");
   LoadAndExpectError(
       ManifestData(std::move(manifest_value), "Invalid default icon"),
       errors::kInvalidIconPath);
 }
 
 }  // namespace
 }  // namespace extensions