Add assembler test.

MIPS: Add lsa and dlsa r6 instructions.

BUG=

Committed: https://crrev.com/8d6899c827711203432694e384f0f534146f1a42
Cr-Commit-Position: refs/heads/master@{#33127}

[balazs.kilvady, 2015-12-23 19:21:07]

Description was changed from

==========
Add assembler test.


sim debug.


MIPS: Add lsa r6 instruction.

BUG=
==========

to

==========
Add assembler test.


sim debug.


MIPS: Add lsa r6 instruction.

BUG=
==========

[balazs.kilvady, 2015-12-23 19:21:07]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, ivica.bogosavljevic@imgtec.com, paul.lind@imgtec.com

[ivica.bogosavljevic, 2015-12-24 09:54:05]

lgtm

LGTM with nits for the tests

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips.cc:5379: if (!IsMipsArchVariant(kMips32r6))
return;
Suggestion: 
1) Instead of lsa, use Lsa macro-assembler instruction. In this way we test both
macro-assembler and assembler, which gives us better test coverage
2) Allow the test to run on all architectures (we can do this since we are using
Lsa macro)
3) In test case array, add one more test for sa value = 5, so we force the
macro-assembler to simulate Lsa instruction using sll and add.

[balazs.kilvady, 2015-12-25 13:30:29]

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips.cc:5379: if (!IsMipsArchVariant(kMips32r6))
return;
On 2015/12/24 09:54:05, ivica.bogosavljevic wrote:
> Suggestion: 
> 1) Instead of lsa, use Lsa macro-assembler instruction. In this way we test
both
> macro-assembler and assembler, which gives us better test coverage
I tought about this also but in that case the test should be added to
test-macro-assembler-mips.cc and Paul has asked a direct lsa instruction test in
test-assembler-mips.cc
sll(); add() sequences were not tested earlier but I agree that Lsa() would be
nice to test. Paul, what do you think? Separated lsa and Lsa tests or test the
Lsa() macro only?

> 2) Allow the test to run on all architectures (we can do this since we are
using
> Lsa macro)
> 3) In test case array, add one more test for sa value = 5, so we force the
> macro-assembler to simulate Lsa instruction using sll and add.
2) and 3) holds if we move the test to test-macro-assembler-mips.cc.

[balazs.kilvady, 2015-12-25 13:36:24]

not lgtm

Thanks for the review.
It is test proposal with PrintF()s (to let it run on r6 HW) and the simulator
will be cleaned up after I added the 64-bit support. So it is not ready for
landing.

[balazs.kilvady, 2016-01-04 20:21:03]

Patchset #2 (id:20001) has been deleted

[balazs.kilvady, 2016-01-04 20:30:46]

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/1545013002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips.cc:5379: if (!IsMipsArchVariant(kMips32r6))
return;
On 2015/12/25 13:30:29, balazs.kilvady wrote:
> On 2015/12/24 09:54:05, ivica.bogosavljevic wrote:
> > Suggestion: 
> > 1) Instead of lsa, use Lsa macro-assembler instruction. In this way we test
> both
> > macro-assembler and assembler, which gives us better test coverage
> I tought about this also but in that case the test should be added to
> test-macro-assembler-mips.cc and Paul has asked a direct lsa instruction test
in
> test-assembler-mips.cc
> sll(); add() sequences were not tested earlier but I agree that Lsa() would be
> nice to test. Paul, what do you think? Separated lsa and Lsa tests or test the
> Lsa() macro only?
> 
> > 2) Allow the test to run on all architectures (we can do this since we are
> using
> > Lsa macro)
> > 3) In test case array, add one more test for sa value = 5, so we force the
> > macro-assembler to simulate Lsa instruction using sll and add.
> 2) and 3) holds if we move the test to test-macro-assembler-mips.cc.

Done.

[balazs.kilvady, 2016-01-05 14:17:59]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 14:18:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545013002/40001

[commit-bot: I haz the power, 2016-01-05 14:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 14:39:49]

Dry run: This issue passed the CQ dry run.

[balazs.kilvady, 2016-01-05 18:16:14]

Description was changed from

==========
Add assembler test.


sim debug.


MIPS: Add lsa r6 instruction.

BUG=
==========

to

==========
MIPS: Add lsa and dlsa r6 instructions.

BUG=
==========

[balazs.kilvady, 2016-01-05 19:18:49]

The CQ bit was checked by balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-01-05 19:18:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
ivica.bogosavljevic@imgtec.com
Link to the patchset: https://codereview.chromium.org/1545013002/#ps50001
(title: "rebased")

[commit-bot: I haz the power, 2016-01-05 19:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545013002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545013002/50001

[commit-bot: I haz the power, 2016-01-05 19:46:03]

Description was changed from

==========
MIPS: Add lsa and dlsa r6 instructions.

BUG=
==========

to

==========
MIPS: Add lsa and dlsa r6 instructions.

BUG=
==========

[commit-bot: I haz the power, 2016-01-05 19:46:04]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2016-01-05 19:46:22]

Description was changed from

==========
MIPS: Add lsa and dlsa r6 instructions.

BUG=
==========

to

==========
MIPS: Add lsa and dlsa r6 instructions.

BUG=

Committed: https://crrev.com/8d6899c827711203432694e384f0f534146f1a42
Cr-Commit-Position: refs/heads/master@{#33127}
==========

[commit-bot: I haz the power, 2016-01-05 19:46:22]

Patchset 3 (id:??) landed as
https://crrev.com/8d6899c827711203432694e384f0f534146f1a42
Cr-Commit-Position: refs/heads/master@{#33127}