Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544313002: Convert Pass()→std::move() in //media (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jshin+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, toyoshim+midi_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //media ☃ BUG=557422 R=avi@chromium.org TBR=jrummell@chromium.org Committed: https://crrev.com/652f5ff5aa1c3592d61a310edc680bf92cf9f57b Cr-Commit-Position: refs/heads/master@{#366924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+865 lines, -808 lines) Patch
M media/audio/audio_input_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_input_device.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/audio/audio_output_device.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/audio_shifter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/base/audio_shifter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/audio_splicer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/audio_video_metadata_extractor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/bind_to_current_loop_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M media/base/cdm_promise_adapter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/data_buffer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M media/base/data_buffer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/base/decoder_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_file_checker.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/media_file_checker_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/base/media_log.cc View 9 chunks +18 lines, -16 lines 0 comments Download
M media/base/pipeline.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M media/base/pipeline_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M media/base/serial_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/text_renderer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/base/text_renderer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/base/video_frame_metadata.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/blink/active_loader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/blink/buffered_data_source.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M media/blink/buffered_resource_loader.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M media/blink/key_system_config_selector.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M media/blink/texttrack_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/blink/video_frame_compositor.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/content/screen_capture_device_core.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M media/capture/video/file_video_capture_device.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 8 chunks +9 lines, -7 lines 0 comments Download
M media/cast/cast_environment.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/logging/encoding_event_subscriber_unittest.cc View 29 chunks +40 lines, -33 lines 0 comments Download
M media/cast/logging/log_event_dispatcher.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc View 27 chunks +32 lines, -30 lines 0 comments Download
M media/cast/logging/simple_event_subscriber_unittest.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/logging/stats_event_subscriber_unittest.cc View 27 chunks +43 lines, -33 lines 0 comments Download
M media/cast/net/cast_transport_sender_impl.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M media/cast/net/cast_transport_sender_impl_unittest.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M media/cast/net/rtcp/receiver_rtcp_event_subscriber_unittest.cc View 12 chunks +17 lines, -15 lines 0 comments Download
M media/cast/net/rtcp/rtcp_builder_unittest.cc View 11 chunks +24 lines, -62 lines 0 comments Download
M media/cast/net/udp_transport.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M media/cast/receiver/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/cast_receiver_impl.cc View 5 chunks +10 lines, -17 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M media/cast/receiver/frame_receiver_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M media/cast/receiver/video_decoder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/sender/audio_encoder_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M media/cast/sender/fake_video_encode_accelerator_factory.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/sender/video_encoder_unittest.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M media/cast/sender/video_sender.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 14 chunks +19 lines, -19 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M media/cast/test/loopback_transport.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M media/cast/test/receiver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/sender.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M media/cast/test/simulator.cc View 4 chunks +12 lines, -20 lines 0 comments Download
M media/cast/test/utility/audio_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/in_process_receiver.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 7 chunks +20 lines, -25 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 27 chunks +36 lines, -41 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cdm/cdm_adapter.cc View 10 chunks +11 lines, -9 lines 0 comments Download
M media/cdm/cdm_adapter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cdm/json_web_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/cdm_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M media/cdm/proxy_decryptor.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/decoder_selector.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M media/filters/decoder_stream.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M media/filters/file_data_source.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/formats/webm/cluster_builder.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M media/formats/webm/opus_packet_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_cluster_parser.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/midi/midi_manager_alsa.h View 3 chunks +5 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 8 chunks +28 lines, -26 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M media/mojo/services/demuxer_stream_provider_shim.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M media/mojo/services/mojo_cdm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_promise.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 6 chunks +13 lines, -10 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M media/renderers/renderer_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/video_renderer_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +jrummell for OWNERS stamp
4 years, 12 months ago (2015-12-27 00:04:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544313002/1
4 years, 12 months ago (2015-12-27 00:04:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-27 01:33:51 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-27 05:39:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544313002/1
4 years, 12 months ago (2015-12-27 08:47:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-27 08:54:13 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 08:55:08 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/652f5ff5aa1c3592d61a310edc680bf92cf9f57b
Cr-Commit-Position: refs/heads/master@{#366924}

Powered by Google App Engine
This is Rietveld 408576698