Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: media/cast/net/rtcp/receiver_rtcp_event_subscriber_unittest.cc

Issue 1544313002: Convert Pass()→std::move() in //media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/net/rtcp/receiver_rtcp_event_subscriber.h"
6
5 #include <stddef.h> 7 #include <stddef.h>
6 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility>
7 10
8 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
10 #include "base/test/simple_test_tick_clock.h" 13 #include "base/test/simple_test_tick_clock.h"
11 #include "base/time/tick_clock.h" 14 #include "base/time/tick_clock.h"
12 #include "media/cast/cast_environment.h" 15 #include "media/cast/cast_environment.h"
13 #include "media/cast/logging/logging_defines.h" 16 #include "media/cast/logging/logging_defines.h"
14 #include "media/cast/net/rtcp/receiver_rtcp_event_subscriber.h"
15 #include "media/cast/test/fake_single_thread_task_runner.h" 17 #include "media/cast/test/fake_single_thread_task_runner.h"
16 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
17 19
18 namespace media { 20 namespace media {
19 namespace cast { 21 namespace cast {
20 22
21 namespace { 23 namespace {
22 24
23 const size_t kMaxEventEntries = 10u; 25 const size_t kMaxEventEntries = 10u;
24 const int64_t kDelayMs = 20L; 26 const int64_t kDelayMs = 20L;
25 27
26 } // namespace 28 } // namespace
27 29
28 class ReceiverRtcpEventSubscriberTest : public ::testing::Test { 30 class ReceiverRtcpEventSubscriberTest : public ::testing::Test {
29 protected: 31 protected:
30 ReceiverRtcpEventSubscriberTest() 32 ReceiverRtcpEventSubscriberTest()
31 : testing_clock_(new base::SimpleTestTickClock()), 33 : testing_clock_(new base::SimpleTestTickClock()),
32 task_runner_(new test::FakeSingleThreadTaskRunner(testing_clock_)), 34 task_runner_(new test::FakeSingleThreadTaskRunner(testing_clock_)),
33 cast_environment_(new CastEnvironment( 35 cast_environment_(
34 scoped_ptr<base::TickClock>(testing_clock_).Pass(), 36 new CastEnvironment(scoped_ptr<base::TickClock>(testing_clock_),
35 task_runner_, 37 task_runner_,
36 task_runner_, 38 task_runner_,
37 task_runner_)) {} 39 task_runner_)) {}
38 40
39 ~ReceiverRtcpEventSubscriberTest() override {} 41 ~ReceiverRtcpEventSubscriberTest() override {}
40 42
41 void TearDown() final { 43 void TearDown() final {
42 if (event_subscriber_) { 44 if (event_subscriber_) {
43 cast_environment_->logger()->Unsubscribe(event_subscriber_.get()); 45 cast_environment_->logger()->Unsubscribe(event_subscriber_.get());
44 event_subscriber_.reset(); 46 event_subscriber_.reset();
45 } 47 }
46 } 48 }
47 49
48 void Init(EventMediaType type) { 50 void Init(EventMediaType type) {
49 event_subscriber_.reset( 51 event_subscriber_.reset(
50 new ReceiverRtcpEventSubscriber(kMaxEventEntries, type)); 52 new ReceiverRtcpEventSubscriber(kMaxEventEntries, type));
51 cast_environment_->logger()->Subscribe(event_subscriber_.get()); 53 cast_environment_->logger()->Subscribe(event_subscriber_.get());
52 } 54 }
53 55
54 void InsertEvents() { 56 void InsertEvents() {
55 // Video events 57 // Video events
56 scoped_ptr<FrameEvent> playout_event(new FrameEvent()); 58 scoped_ptr<FrameEvent> playout_event(new FrameEvent());
57 playout_event->timestamp = testing_clock_->NowTicks(); 59 playout_event->timestamp = testing_clock_->NowTicks();
58 playout_event->type = FRAME_PLAYOUT; 60 playout_event->type = FRAME_PLAYOUT;
59 playout_event->media_type = VIDEO_EVENT; 61 playout_event->media_type = VIDEO_EVENT;
60 playout_event->rtp_timestamp = 100u; 62 playout_event->rtp_timestamp = 100u;
61 playout_event->frame_id = 2u; 63 playout_event->frame_id = 2u;
62 playout_event->delay_delta = base::TimeDelta::FromMilliseconds(kDelayMs); 64 playout_event->delay_delta = base::TimeDelta::FromMilliseconds(kDelayMs);
63 cast_environment_->logger()->DispatchFrameEvent(playout_event.Pass()); 65 cast_environment_->logger()->DispatchFrameEvent(std::move(playout_event));
64 66
65 scoped_ptr<FrameEvent> decode_event(new FrameEvent()); 67 scoped_ptr<FrameEvent> decode_event(new FrameEvent());
66 decode_event->timestamp = testing_clock_->NowTicks(); 68 decode_event->timestamp = testing_clock_->NowTicks();
67 decode_event->type = FRAME_DECODED; 69 decode_event->type = FRAME_DECODED;
68 decode_event->media_type = VIDEO_EVENT; 70 decode_event->media_type = VIDEO_EVENT;
69 decode_event->rtp_timestamp = 200u; 71 decode_event->rtp_timestamp = 200u;
70 decode_event->frame_id = 1u; 72 decode_event->frame_id = 1u;
71 cast_environment_->logger()->DispatchFrameEvent(decode_event.Pass()); 73 cast_environment_->logger()->DispatchFrameEvent(std::move(decode_event));
72 74
73 scoped_ptr<PacketEvent> receive_event(new PacketEvent()); 75 scoped_ptr<PacketEvent> receive_event(new PacketEvent());
74 receive_event->timestamp = testing_clock_->NowTicks(); 76 receive_event->timestamp = testing_clock_->NowTicks();
75 receive_event->type = PACKET_RECEIVED; 77 receive_event->type = PACKET_RECEIVED;
76 receive_event->media_type = VIDEO_EVENT; 78 receive_event->media_type = VIDEO_EVENT;
77 receive_event->rtp_timestamp = 200u; 79 receive_event->rtp_timestamp = 200u;
78 receive_event->frame_id = 2u; 80 receive_event->frame_id = 2u;
79 receive_event->packet_id = 1u; 81 receive_event->packet_id = 1u;
80 receive_event->max_packet_id = 10u; 82 receive_event->max_packet_id = 10u;
81 receive_event->size = 1024u; 83 receive_event->size = 1024u;
82 cast_environment_->logger()->DispatchPacketEvent(receive_event.Pass()); 84 cast_environment_->logger()->DispatchPacketEvent(std::move(receive_event));
83 85
84 // Audio events 86 // Audio events
85 playout_event.reset(new FrameEvent()); 87 playout_event.reset(new FrameEvent());
86 playout_event->timestamp = testing_clock_->NowTicks(); 88 playout_event->timestamp = testing_clock_->NowTicks();
87 playout_event->type = FRAME_PLAYOUT; 89 playout_event->type = FRAME_PLAYOUT;
88 playout_event->media_type = AUDIO_EVENT; 90 playout_event->media_type = AUDIO_EVENT;
89 playout_event->rtp_timestamp = 300u; 91 playout_event->rtp_timestamp = 300u;
90 playout_event->frame_id = 4u; 92 playout_event->frame_id = 4u;
91 playout_event->delay_delta = base::TimeDelta::FromMilliseconds(kDelayMs); 93 playout_event->delay_delta = base::TimeDelta::FromMilliseconds(kDelayMs);
92 cast_environment_->logger()->DispatchFrameEvent(playout_event.Pass()); 94 cast_environment_->logger()->DispatchFrameEvent(std::move(playout_event));
93 95
94 decode_event.reset(new FrameEvent()); 96 decode_event.reset(new FrameEvent());
95 decode_event->timestamp = testing_clock_->NowTicks(); 97 decode_event->timestamp = testing_clock_->NowTicks();
96 decode_event->type = FRAME_DECODED; 98 decode_event->type = FRAME_DECODED;
97 decode_event->media_type = AUDIO_EVENT; 99 decode_event->media_type = AUDIO_EVENT;
98 decode_event->rtp_timestamp = 400u; 100 decode_event->rtp_timestamp = 400u;
99 decode_event->frame_id = 3u; 101 decode_event->frame_id = 3u;
100 cast_environment_->logger()->DispatchFrameEvent(decode_event.Pass()); 102 cast_environment_->logger()->DispatchFrameEvent(std::move(decode_event));
101 103
102 receive_event.reset(new PacketEvent()); 104 receive_event.reset(new PacketEvent());
103 receive_event->timestamp = testing_clock_->NowTicks(); 105 receive_event->timestamp = testing_clock_->NowTicks();
104 receive_event->type = PACKET_RECEIVED; 106 receive_event->type = PACKET_RECEIVED;
105 receive_event->media_type = AUDIO_EVENT; 107 receive_event->media_type = AUDIO_EVENT;
106 receive_event->rtp_timestamp = 400u; 108 receive_event->rtp_timestamp = 400u;
107 receive_event->frame_id = 5u; 109 receive_event->frame_id = 5u;
108 receive_event->packet_id = 1u; 110 receive_event->packet_id = 1u;
109 receive_event->max_packet_id = 10u; 111 receive_event->max_packet_id = 10u;
110 receive_event->size = 128u; 112 receive_event->size = 128u;
111 cast_environment_->logger()->DispatchPacketEvent(receive_event.Pass()); 113 cast_environment_->logger()->DispatchPacketEvent(std::move(receive_event));
112 114
113 // Unrelated events 115 // Unrelated events
114 scoped_ptr<FrameEvent> encode_event(new FrameEvent()); 116 scoped_ptr<FrameEvent> encode_event(new FrameEvent());
115 encode_event->timestamp = testing_clock_->NowTicks(); 117 encode_event->timestamp = testing_clock_->NowTicks();
116 encode_event->type = FRAME_ENCODED; 118 encode_event->type = FRAME_ENCODED;
117 encode_event->media_type = VIDEO_EVENT; 119 encode_event->media_type = VIDEO_EVENT;
118 encode_event->rtp_timestamp = 100u; 120 encode_event->rtp_timestamp = 100u;
119 encode_event->frame_id = 1u; 121 encode_event->frame_id = 1u;
120 cast_environment_->logger()->DispatchFrameEvent(encode_event.Pass()); 122 cast_environment_->logger()->DispatchFrameEvent(std::move(encode_event));
121 123
122 encode_event.reset(new FrameEvent()); 124 encode_event.reset(new FrameEvent());
123 encode_event->timestamp = testing_clock_->NowTicks(); 125 encode_event->timestamp = testing_clock_->NowTicks();
124 encode_event->type = FRAME_ENCODED; 126 encode_event->type = FRAME_ENCODED;
125 encode_event->media_type = AUDIO_EVENT; 127 encode_event->media_type = AUDIO_EVENT;
126 encode_event->rtp_timestamp = 100u; 128 encode_event->rtp_timestamp = 100u;
127 encode_event->frame_id = 1u; 129 encode_event->frame_id = 1u;
128 cast_environment_->logger()->DispatchFrameEvent(encode_event.Pass()); 130 cast_environment_->logger()->DispatchFrameEvent(std::move(encode_event));
129 } 131 }
130 132
131 base::SimpleTestTickClock* testing_clock_; // Owned by CastEnvironment. 133 base::SimpleTestTickClock* testing_clock_; // Owned by CastEnvironment.
132 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_; 134 scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
133 scoped_refptr<CastEnvironment> cast_environment_; 135 scoped_refptr<CastEnvironment> cast_environment_;
134 scoped_ptr<ReceiverRtcpEventSubscriber> event_subscriber_; 136 scoped_ptr<ReceiverRtcpEventSubscriber> event_subscriber_;
135 }; 137 };
136 138
137 TEST_F(ReceiverRtcpEventSubscriberTest, LogVideoEvents) { 139 TEST_F(ReceiverRtcpEventSubscriberTest, LogVideoEvents) {
138 Init(VIDEO_EVENT); 140 Init(VIDEO_EVENT);
(...skipping 16 matching lines...) Expand all
155 TEST_F(ReceiverRtcpEventSubscriberTest, DropEventsWhenSizeExceeded) { 157 TEST_F(ReceiverRtcpEventSubscriberTest, DropEventsWhenSizeExceeded) {
156 Init(VIDEO_EVENT); 158 Init(VIDEO_EVENT);
157 159
158 for (uint32_t i = 1u; i <= 10u; ++i) { 160 for (uint32_t i = 1u; i <= 10u; ++i) {
159 scoped_ptr<FrameEvent> decode_event(new FrameEvent()); 161 scoped_ptr<FrameEvent> decode_event(new FrameEvent());
160 decode_event->timestamp = testing_clock_->NowTicks(); 162 decode_event->timestamp = testing_clock_->NowTicks();
161 decode_event->type = FRAME_DECODED; 163 decode_event->type = FRAME_DECODED;
162 decode_event->media_type = VIDEO_EVENT; 164 decode_event->media_type = VIDEO_EVENT;
163 decode_event->rtp_timestamp = i * 10; 165 decode_event->rtp_timestamp = i * 10;
164 decode_event->frame_id = i; 166 decode_event->frame_id = i;
165 cast_environment_->logger()->DispatchFrameEvent(decode_event.Pass()); 167 cast_environment_->logger()->DispatchFrameEvent(std::move(decode_event));
166 } 168 }
167 169
168 ReceiverRtcpEventSubscriber::RtcpEvents rtcp_events; 170 ReceiverRtcpEventSubscriber::RtcpEvents rtcp_events;
169 event_subscriber_->GetRtcpEventsWithRedundancy(&rtcp_events); 171 event_subscriber_->GetRtcpEventsWithRedundancy(&rtcp_events);
170 EXPECT_EQ(10u, rtcp_events.size()); 172 EXPECT_EQ(10u, rtcp_events.size());
171 } 173 }
172 174
173 } // namespace cast 175 } // namespace cast
174 } // namespace media 176 } // namespace media
OLDNEW
« no previous file with comments | « media/cast/net/cast_transport_sender_impl_unittest.cc ('k') | media/cast/net/rtcp/rtcp_builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698