media/cast/logging/log_event_dispatcher.cc - Issue 1544313002: Convert Pass()→std::move() in //media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/logging/log_event_dispatcher.cc

Issue 1544313002: Convert Pass()→std::move() in //media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/cast/logging/encoding_event_subscriber_unittest.cc ('k') | media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/logging/log_event_dispatcher.cc

diff --git a/media/cast/logging/log_event_dispatcher.cc b/media/cast/logging/log_event_dispatcher.cc

index ac0e9abc2036a824f718b128b38277c7724d55b5..428a642808b993385c7310c03c3f8975e9cd6308 100644

--- a/media/cast/logging/log_event_dispatcher.cc

+++ b/media/cast/logging/log_event_dispatcher.cc

@@ -5,6 +5,7 @@

#include "media/cast/logging/log_event_dispatcher.h"

#include <algorithm>

+#include <utility>

#include "base/bind.h"

#include "base/bind_helpers.h"

@@ -25,7 +26,7 @@ LogEventDispatcher::~LogEventDispatcher() {}

void LogEventDispatcher::DispatchFrameEvent(

scoped_ptr<FrameEvent> event) const {

if (env_->CurrentlyOn(CastEnvironment::MAIN)) {

- impl_->DispatchFrameEvent(event.Pass());

+ impl_->DispatchFrameEvent(std::move(event));

} else {

env_->PostTask(CastEnvironment::MAIN, FROM_HERE,

base::Bind(&LogEventDispatcher::Impl::DispatchFrameEvent,

@@ -36,7 +37,7 @@ void LogEventDispatcher::DispatchFrameEvent(

void LogEventDispatcher::DispatchPacketEvent(

scoped_ptr<PacketEvent> event) const {

if (env_->CurrentlyOn(CastEnvironment::MAIN)) {

- impl_->DispatchPacketEvent(event.Pass());

+ impl_->DispatchPacketEvent(std::move(event));

} else {

env_->PostTask(CastEnvironment::MAIN, FROM_HERE,

base::Bind(&LogEventDispatcher::Impl::DispatchPacketEvent,

@@ -48,7 +49,8 @@ void LogEventDispatcher::DispatchBatchOfEvents(

scoped_ptr<std::vector<FrameEvent>> frame_events,

scoped_ptr<std::vector<PacketEvent>> packet_events) const {

if (env_->CurrentlyOn(CastEnvironment::MAIN)) {

- impl_->DispatchBatchOfEvents(frame_events.Pass(), packet_events.Pass());

+ impl_->DispatchBatchOfEvents(std::move(frame_events),

+ std::move(packet_events));

} else {

env_->PostTask(

CastEnvironment::MAIN, FROM_HERE,