Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: media/midi/midi_manager_alsa.cc

Issue 1544313002: Convert Pass()→std::move() in //media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_alsa.h ('k') | media/midi/midi_manager_alsa_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa.cc
diff --git a/media/midi/midi_manager_alsa.cc b/media/midi/midi_manager_alsa.cc
index e51a5028ccc0f58fb5a7cea78d55d86598cba4bc..6110e56f7a69d69ae97d2275ae3ab1f59004e208 100644
--- a/media/midi/midi_manager_alsa.cc
+++ b/media/midi/midi_manager_alsa.cc
@@ -387,7 +387,7 @@ scoped_ptr<base::Value> MidiManagerAlsa::MidiPort::Value() const {
SetStringIfNonEmpty(value.get(), "usbInterfaceNum", id_.usb_interface_num());
SetStringIfNonEmpty(value.get(), "serial", id_.serial());
- return value.Pass();
+ return std::move(value);
}
std::string MidiManagerAlsa::MidiPort::JSONValue() const {
@@ -578,7 +578,7 @@ uint32_t MidiManagerAlsa::MidiPortState::push_back(scoped_ptr<MidiPort> port) {
break;
}
port->set_web_port_index(web_port_index);
- MidiPortStateBase::push_back(port.Pass());
+ MidiPortStateBase::push_back(std::move(port));
return web_port_index;
}
@@ -705,7 +705,7 @@ MidiManagerAlsa::AlsaSeqState::ToMidiPortState(const AlsaCardMap& alsa_cards) {
}
}
- return midi_ports.Pass();
+ return midi_ports;
}
MidiManagerAlsa::AlsaSeqState::Port::Port(
@@ -1176,7 +1176,7 @@ void MidiManagerAlsa::UpdatePortStateAndGenerateEvents() {
const auto& client_id = new_port->client_id();
const auto& port_id = new_port->port_id();
- uint32_t web_port_index = port_state_.push_back(new_port.Pass());
+ uint32_t web_port_index = port_state_.push_back(std::move(new_port));
it = new_port_state->erase(it);
MidiPortInfo info(opaque_key, manufacturer, port_name, version,
« no previous file with comments | « media/midi/midi_manager_alsa.h ('k') | media/midi/midi_manager_alsa_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698