media/base/audio_video_metadata_extractor_unittest.cc - Issue 1544313002: Convert Pass()→std::move() in //media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_video_metadata_extractor_unittest.cc

Issue 1544313002: Convert Pass()→std::move() in //media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_video_metadata_extractor_unittest.cc

diff --git a/media/base/audio_video_metadata_extractor_unittest.cc b/media/base/audio_video_metadata_extractor_unittest.cc

index d0927d5a64e81c07128d26e0c300f0f5f4d0ca80..d67808f16eb6a4b792ba531593c00edc7d2a8911 100644

--- a/media/base/audio_video_metadata_extractor_unittest.cc

+++ b/media/base/audio_video_metadata_extractor_unittest.cc

@@ -29,14 +29,14 @@ scoped_ptr<AudioVideoMetadataExtractor> GetExtractor(

EXPECT_EQ(expected_result, extracted);

if (!extracted)

- return extractor.Pass();

+ return extractor;

EXPECT_EQ(expected_duration, extractor->duration());

EXPECT_EQ(expected_width, extractor->width());

EXPECT_EQ(expected_height, extractor->height());

- return extractor.Pass();

+ return extractor;

}

TEST(AudioVideoMetadataExtractorTest, InvalidFile) {

« no previous file with comments | « media/base/audio_splicer.cc ('k') | media/base/bind_to_current_loop_unittest.cc » ('j') | no next file with comments »