Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1535353002: change all factories to return their base-class (Closed)

Created:
5 years ago by reed2
Modified:
5 years ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change all factories to return their base-class will watch DEPS roll to see if there are chrome sites needing updates BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535353002 TBR= Committed: https://skia.googlesource.com/skia/+/d63f60a36327e9580861205ebb35cade8c49bd34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -62 lines) Patch
M bench/MatrixConvolutionBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/circles.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/rects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +1 line, -3 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 chunk +5 lines, -5 lines 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +9 lines, -9 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleUnpremul.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/AsADashTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/DrawPathTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535353002/1
5 years ago (2015-12-19 19:02:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-19 19:17:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535353002/1
5 years ago (2015-12-21 03:22:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d63f60a36327e9580861205ebb35cade8c49bd34
5 years ago (2015-12-21 03:38:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d63f60a36327e9580861205ebb35cade8c49bd34
5 years ago (2015-12-21 03:38:45 UTC) #11
reed2
5 years ago (2015-12-21 04:08:10 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1540203002/ by reed@chromium.org.

The reason for reverting is: need to update some chrome/blink call-sites.

Powered by Google App Engine
This is Rietveld 408576698