samplecode/SampleAll.cpp - Issue 1535353002: change all factories to return their base-class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleAll.cpp

Issue 1535353002: change all factories to return their base-class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleAll.cpp

diff --git a/samplecode/SampleAll.cpp b/samplecode/SampleAll.cpp

index b5a0fe568dcde2835e5473e1487e317c910ce24f..21d93bd8ae5e47276239739976f2534d443afb78 100644

--- a/samplecode/SampleAll.cpp

+++ b/samplecode/SampleAll.cpp

@@ -382,7 +382,7 @@ protected:

light.fAmbient = 0x48;

light.fSpecular = 0x80;

SkScalar sigma = SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(12)/5);

- SkEmbossMaskFilter* embossFilter = SkEmbossMaskFilter::Create(sigma, light);

+ SkMaskFilter* embossFilter = SkEmbossMaskFilter::Create(sigma, light);

SkXfermode* xfermode = SkXfermode::Create(SkXfermode::kXor_Mode);

SkColorFilter* lightingFilter = SkColorFilter::CreateLightingFilter(

« no previous file with comments | « include/effects/SkXfermodeImageFilter.h ('k') | samplecode/SampleTiling.cpp » ('j') | no next file with comments »