src/effects/SkEmbossMaskFilter.cpp - Issue 1535353002: change all factories to return their base-class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkEmbossMaskFilter.cpp

Issue 1535353002: change all factories to return their base-class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkEmbossMaskFilter.cpp

diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp

index 2607e255d9a07619a83827f86bc894e1b7d19287..64afa49447dfb8614394e266a51a0929dfdb7dfd 100644

--- a/src/effects/SkEmbossMaskFilter.cpp

+++ b/src/effects/SkEmbossMaskFilter.cpp

@@ -13,7 +13,7 @@

#include "SkWriteBuffer.h"

#include "SkString.h"

-SkEmbossMaskFilter* SkEmbossMaskFilter::Create(SkScalar blurSigma, const Light& light) {

+SkMaskFilter* SkEmbossMaskFilter::Create(SkScalar blurSigma, const Light& light) {

return new SkEmbossMaskFilter(blurSigma, light);

}